Fix #5806, TypeError on ExternalModule hash.update

undefined must be coerced to `false`
webpack · Oct 11, 2017 · c9bad17 · c9bad17
1 parent 551ea76
commit c9bad17
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/lib/ExternalModule.js b/lib/ExternalModule.js
@@ -120,7 +120,7 @@ class ExternalModule extends Module {
 	updateHash(hash) {
 		hash.update(this.type);
 		hash.update(JSON.stringify(this.request));
-		hash.update(JSON.stringify(this.optional));
+		hash.update(JSON.stringify(Boolean(this.optional)));
 		super.updateHash(hash);
 	}
 }

diff --git a/test/ExternalModule.test.js b/test/ExternalModule.test.js
@@ -340,4 +340,32 @@ module.exports = some/request;`;
 			hashedText.should.containEql("12345678");
 		});
 	});
+
+	describe("#updateHash without optional", function() {
+		let hashedText;
+		let hash;
+		beforeEach(function() {
+			hashedText = "";
+			hash = {
+				update: (text) => {
+					hashedText += text;
+				}
+			};
+			// Note no set of `externalModule.optional`, which crashed externals in 3.7.0
+			externalModule.id = 12345678;
+			externalModule.updateHash(hash);
+		});
+		it("updates hash with request", function() {
+			hashedText.should.containEql("some/request");
+		});
+		it("updates hash with type", function() {
+			hashedText.should.containEql("some-type");
+		});
+		it("updates hash with optional flag", function() {
+			hashedText.should.containEql("false");
+		});
+		it("updates hash with module id", function() {
+			hashedText.should.containEql("12345678");
+		});
+	});
 });