Merge pull request #6346 from Connormiha/simplife-has-dependencies

Simplify check hasDependencies and add unit tests
webpack · Jun 28, 2018 · b848ec5 · b848ec5
2 parents dcf3e09 + dddb547
commit b848ec5
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/lib/DependenciesBlockVariable.js b/lib/DependenciesBlockVariable.js
@@ -41,11 +41,9 @@ class DependenciesBlockVariable {
 
 	hasDependencies(filter) {
 		if (filter) {
-			if (this.dependencies.some(filter)) return true;
-		} else {
-			if (this.dependencies.length > 0) return true;
+			return this.dependencies.some(filter);
 		}
-		return false;
+		return this.dependencies.length > 0;
 	}
 }