Merge pull request #9472 from webpack/performance/chunk-group-available

Optimize performance of chunk graph generation
webpack · Jul 26, 2019 · 9741565 · 9741565
2 parents 2686baf + 81017d5
commit 9741565
Show file tree

Hide file tree

Showing 6 changed files with 717 additions and 471 deletions.
diff --git a/lib/Chunk.js b/lib/Chunk.js
@@ -355,7 +355,11 @@ class Chunk {
 		return this._modules.getFromUnorderedCache(getModulesIdent);
 	}
 
-	remove() {
+	/**
+	 * @param {string=} reason reason why chunk is removed
+	 * @returns {void}
+	 */
+	remove(reason) {
 		// cleanup modules
 		// Array.from is used here to create a clone, because removeChunk modifies this._modules
 		for (const module of Array.from(this._modules)) {

diff --git a/lib/ChunkGroup.js b/lib/ChunkGroup.js
@@ -345,7 +345,7 @@ class ChunkGroup {
 	}
 
 	/**
-	 * @param {ModuleReason} reason reason for removing ChunkGroup
+	 * @param {string=} reason reason for removing ChunkGroup
 	 * @returns {void}
 	 */
 	remove(reason) {