Skip to content

Commit

Permalink
Merge pull request #6814 from webpack/fix/issue-6811
Browse files Browse the repository at this point in the history
Read 'browser' main field when target is 'electron-renderer'
  • Loading branch information
sokra committed Mar 24, 2018
2 parents e0e8017 + e4808b2 commit 7f11210
Show file tree
Hide file tree
Showing 6 changed files with 30 additions and 3 deletions.
14 changes: 11 additions & 3 deletions lib/WebpackOptionsDefaulter.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,9 @@ class WebpackOptionsDefaulter extends OptionsDefaulter {
type: "javascript/esm",
resolve: {
mainFields:
options.target === "web" || options.target === "webworker"
options.target === "web" ||
options.target === "webworker" ||
options.target === "electron-renderer"
? ["browser", "main"]
: ["main"]
}
Expand Down Expand Up @@ -297,9 +299,15 @@ class WebpackOptionsDefaulter extends OptionsDefaulter {
else return [];
});
this.set("resolve.mainFields", "make", options => {
if (options.target === "web" || options.target === "webworker")
if (
options.target === "web" ||
options.target === "webworker" ||
options.target === "electron-renderer"
) {
return ["browser", "module", "main"];
else return ["module", "main"];
} else {
return ["module", "main"];
}
});
this.set("resolve.cacheWithContext", "make", options => {
return (
Expand Down
5 changes: 5 additions & 0 deletions test/configCases/target/electron-renderer/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
const foo = require("foo");

it("should use browser main field", () => {
foo.should.be.eql("browser");
});

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions test/configCases/target/electron-renderer/webpack.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
module.exports = {
target: "electron-renderer",
optimization: {
minimize: false
}
};

0 comments on commit 7f11210

Please sign in to comment.