Importing typedef from Dependency.js ??? Please review.

webpack · Jun 21, 2018 · 7969a5a · 7969a5a
1 parent 16bf799
commit 7969a5a
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 9 deletions.
diff --git a/lib/CommentCompilationWarning.js b/lib/CommentCompilationWarning.js
@@ -8,15 +8,9 @@ const WebpackError = require("./WebpackError");
 
 /** @typedef {import("./Module.js")} Module */
 
-/** @typedef {Object} Position
- *  @property {number} column
- *  @property {number} line
- */
-
-/** @typedef {Object} Loc
- *  @property {Position} start
- *  @property {Position} end
- */
+/** @typedef {import("./Dependency.js").Position} Position */
+
+/** @typedef {import("./Dependency.js").Loc} Loc */
 
 class CommentCompilationWarning extends WebpackError {
 	/**

diff --git a/lib/Dependency.js b/lib/Dependency.js
@@ -48,4 +48,17 @@ class Dependency {
 }
 Dependency.compare = (a, b) => compareLocations(a.loc, b.loc);
 
+/** @typedef {Object} Position
+ *  @property {number} column
+ *  @property {number} line
+ */
+
+/** @typedef {Object} Loc
+ *  @property {Position} start
+ *  @property {Position} end
+ */
+
+exports Position;
+exports Loc;
+
 module.exports = Dependency;