Improve error reporting while recompilation in HotCases

webpack · Aug 3, 2018 · 795cc35 · 795cc35
1 parent f5be9a6
commit 795cc35
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/test/HotTestCases.test.js b/test/HotTestCases.test.js
@@ -109,7 +109,7 @@ describe("HotTestCases", () => {
 								function _next(callback) {
 									fakeUpdateLoaderOptions.updateIndex++;
 									compiler.run((err, stats) => {
-										if (err) return done(err);
+										if (err) return callback(err);
 										const jsonStats = stats.toJson({
 											errorDetails: true
 										});
@@ -120,7 +120,7 @@ describe("HotTestCases", () => {
 												"error",
 												"errors" + fakeUpdateLoaderOptions.updateIndex,
 												"Error",
-												done
+												callback
 											)
 										) {
 											return;
@@ -132,12 +132,12 @@ describe("HotTestCases", () => {
 												"warning",
 												"warnings" + fakeUpdateLoaderOptions.updateIndex,
 												"Warning",
-												done
+												callback
 											)
 										) {
 											return;
 										}
-										if (callback) callback(jsonStats);
+										callback(null, jsonStats);
 									});
 								}
 

diff --git a/test/hotCases/update.js b/test/hotCases/update.js
@@ -1,7 +1,8 @@
 module.exports = function(done, options, callback) {
-	return function(stats) {
+	return function(err, stats) {
+		if (err) return done(err);
 		module.hot.check(options || true).then(() => {
-			if(callback)
+			if (callback)
 				callback(stats);
 		}).catch((err) => {
 			done(err);