Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix race condition in profiling plugin.
Based on some digging in this git history for the profiling plugin it looks like this commit exacerbated the issue: 883088e Note, we are calling end() and then writeStream right after we call flush on the trace object https://github.com/samccone/chrome-trace-event/blob/64b514e9bd364ca5b6df3c0fb121ba0d3b239cc2/lib/trace-event.ts#L123 The trace object is only calling _push to the writable stream but in no way ensuring that all data that has been pushed has actually been written to the output stream sooo we find ourselves encounter 🐎 [race] conditions.
- Loading branch information