rewrite module reference correctly after replacing ConcatenatedModule

fixes #7443
webpack · May 30, 2018 · 6390240 · 6390240
1 parent 4f4a2ba
commit 6390240
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/lib/optimize/ModuleConcatenationPlugin.js b/lib/optimize/ModuleConcatenationPlugin.js
@@ -286,7 +286,13 @@ class ModuleConcatenationPlugin {
 							}
 							compilation.modules.push(newModule);
 							for (const reason of newModule.reasons) {
-								reason.dependency.module = newModule;
+								if (reason.dependency.module === concatConfiguration.rootModule)
+									reason.dependency.module = newModule;
+								if (
+									reason.dependency.redirectedModule ===
+									concatConfiguration.rootModule
+								)
+									reason.dependency.redirectedModule = newModule;
 							}
 							// TODO: remove when LTS node version contains fixed v8 version
 							// @see https://github.com/webpack/webpack/pull/6613

diff --git a/test/cases/optimize/side-effects-scope-hoisting/index.js b/test/cases/optimize/side-effects-scope-hoisting/index.js
@@ -0,0 +1,8 @@
+import { a } from "pmodule";
+
+it("should not crash with null id", function() {
+	expect(a).toBe("a");
+});
+
+if(Math === undefined)
+	console.log(module); // prevent scope hoisting of this module