Merge pull request #7407 from prplx/master

Refactor JsonpMainTemplatePlugin
webpack · Jun 7, 2018 · 60e1076 · 60e1076
2 parents 47101fd + ff224a7
commit 60e1076
Showing 1 changed file with 11 additions and 22 deletions.
diff --git a/lib/web/JsonpMainTemplatePlugin.js b/lib/web/JsonpMainTemplatePlugin.js
@@ -32,28 +32,17 @@ class JsonpMainTemplatePlugin {
 			const allPrefetchChunks = chunk.getChildIdsByOrdersMap(true).prefetch;
 			return allPrefetchChunks && Object.keys(allPrefetchChunks).length;
 		};
-		// TODO refactor this
-		if (!mainTemplate.hooks.jsonpScript) {
-			mainTemplate.hooks.jsonpScript = new SyncWaterfallHook([
-				"source",
-				"chunk",
-				"hash"
-			]);
-		}
-		if (!mainTemplate.hooks.linkPreload) {
-			mainTemplate.hooks.linkPreload = new SyncWaterfallHook([
-				"source",
-				"chunk",
-				"hash"
-			]);
-		}
-		if (!mainTemplate.hooks.linkPrefetch) {
-			mainTemplate.hooks.linkPrefetch = new SyncWaterfallHook([
-				"source",
-				"chunk",
-				"hash"
-			]);
-		}
+
+		// TODO webpack 5, no adding to .hooks, use WeakMap and static methods
+		["jsonpScript", "linkPreload", "linkPrefetch"].forEach(hook => {
+			if (!mainTemplate.hooks[hook]) {
+				mainTemplate.hooks[hook] = new SyncWaterfallHook([
+					"source",
+					"chunk",
+					"hash"
+				]);
+			}
+		});
 
 		const getScriptSrcPath = (hash, chunk, chunkIdExpression) => {
 			const chunkFilename = mainTemplate.outputOptions.chunkFilename;