Merge pull request #8844 from webpack/bugfix/8829

fixes #8829
webpack · Feb 28, 2019 · 5e9b9fe · 5e9b9fe
2 parents 3496426 + ab517aa
commit 5e9b9fe
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 6 deletions.
diff --git a/lib/APIPlugin.js b/lib/APIPlugin.js
@@ -58,12 +58,12 @@ class APIPlugin {
 											REPLACEMENTS[key]
 									  )
 							);
-						parser.hooks.evaluateTypeof
-							.for(key)
-							.tap(
-								"APIPlugin",
-								ParserHelpers.evaluateToString(REPLACEMENT_TYPES[key])
-							);
+						const type = REPLACEMENT_TYPES[key];
+						if (type) {
+							parser.hooks.evaluateTypeof
+								.for(key)
+								.tap("APIPlugin", ParserHelpers.evaluateToString(type));
+						}
 					});
 				};
 

diff --git a/test/cases/parsing/typeof/index.js b/test/cases/parsing/typeof/index.js
@@ -29,6 +29,15 @@ it("should answer typeof require.ensure correctly", function() {
 it("should answer typeof require.resolve correctly", function() {
 	expect((typeof require.resolve)).toBe("function");
 });
+it("should answer typeof __non_webpack_require__ correctly", function() {
+	var oldValue;
+	eval("oldValue = require;");
+	expect((typeof __non_webpack_require__)).toBe("function");
+	eval("require = undefined;");
+	expect((typeof __non_webpack_require__)).toBe("undefined");
+	eval("require = oldValue;");
+	expect((typeof __non_webpack_require__)).toBe("function");
+});
 
 it("should not parse filtered stuff", function() {
 	if(typeof require != "function") require("fail");