Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Merge pull request #9419 from vankop/remove-valid-jsdoc-rule
remove valid jsdoc rule in favour of eslint-plugin-jsdoc
  • Loading branch information
sokra committed Jul 17, 2019
2 parents ab75240 + f207cdc commit 53a5ae2
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 22 deletions.
41 changes: 20 additions & 21 deletions .eslintrc.js
Expand Up @@ -33,24 +33,6 @@ module.exports = {
"no-loop-func": "warn",
indent: "off",
"no-console": "off",
"valid-jsdoc": [
"error",
{
prefer: {
return: "returns",
prop: "property",
memberof: "DONTUSE",
class: "DONTUSE",
inheritdoc: "DONTUSE",
description: "DONTUSE",
readonly: "DONTUSE"
},
preferType: {
"*": "any"
},
requireReturnType: true
}
],
"node/no-unsupported-features": "error",
"node/no-deprecated-api": "error",
"node/no-missing-import": "error",
Expand All @@ -59,7 +41,15 @@ module.exports = {
"node/no-unpublished-require": "error",
"node/process-exit-as-throw": "error",
"jsdoc/require-hyphen-before-param-description": ["error", "never"],
"jsdoc/check-tag-names": "error"
"jsdoc/check-tag-names": "error",
"jsdoc/check-param-names": "error",
"jsdoc/require-param-description": "error",
"jsdoc/require-param-name": "error",
"jsdoc/require-param-type": "error",
"jsdoc/require-param": "error",
"jsdoc/require-returns-description": "error",
"jsdoc/require-returns-type": "error",
"jsdoc/require-returns": "error"
},
settings: {
jsdoc: {
Expand All @@ -72,8 +62,17 @@ module.exports = {
return acc;
}, {})),
extends: "extends",
constructor: "constructor"
}
return: "returns",
constructor: "constructor",
prop: "property",
arg: "param",
augments: "extends",
description: false,
desc: false,
inheritdoc: false,
class: false
},
overrideReplacesDocs: false
}
},
overrides: [
Expand Down
2 changes: 1 addition & 1 deletion lib/debug/ProfilingPlugin.js
Expand Up @@ -78,8 +78,8 @@ class Profiler {
}

/**
* an object that wraps Tracer and Profiler with a counter
* @typedef {Object} Trace
* @description an object that wraps Tracer and Profiler with a counter
* @property {Tracer} trace instance of Tracer
* @property {number} counter Counter
* @property {Profiler} profiler instance of Profiler
Expand Down

0 comments on commit 53a5ae2

Please sign in to comment.