Merge pull request #9728 from webpack/validation/potential-config-err…

…or-cache-groups

disallow shorthand cache groups syntax with cache group named test

lib/WebpackOptionsValidationError.js

@@ -362,6 +362,10 @@ class WebpackOptionsValidationError extends WebpackError {
 					err.parentSchema
 				)}`;
 			}
+		} else if (err.keyword === "not") {
+			return `${dataPath} should not be ${getSchemaPartText(
+				err.schema
+			)}\n${getSchemaPartText(err.parentSchema)}`;
 		} else if (err.keyword === "absolutePath") {
 			const baseMessage = `${dataPath}: ${
 				err.message

schemas/WebpackOptions.json

@@ -684,6 +684,30 @@
                 }
               }
             ]
+          },
+          "not": {
+            "description": "Using the cacheGroup shorthand syntax with a cache group named 'test' is a potential config error\nDid you intent to define a cache group with a test instead?\ncacheGroups: {\n  <name>: {\n    test: ...\n  }\n}",
+            "type": "object",
+            "additionalProperties": true,
+            "properties": {
+              "test": {
+                "description": "The test property is a cache group name, but using the test option of the cache group could be intended instead",
+                "anyOf": [
+                  {
+                    "instanceof": "Function",
+                    "tsType": "Function"
+                  },
+                  {
+                    "type": "string"
+                  },
+                  {
+                    "instanceof": "RegExp",
+                    "tsType": "RegExp"
+                  }
+                ]
+              }
+            },
+            "required": ["test"]
           }
         },
         "chunks": {

test/Schemas.lint.js

@@ -50,7 +50,8 @@ describe("Schemas", () => {
 					"minItems",
 					"minProperties",
 					"instanceof",
-					"tsType"
+					"tsType",
+					"not"
 				];
 
 				const validateProperty = property => {