Allow array as value in externals object.

Fixes #8041.
webpack · Sep 17, 2018 · 3aef0e5 · 3aef0e5
1 parent 2f78aae
commit 3aef0e5
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 0 deletions.
diff --git a/schemas/WebpackOptions.json b/schemas/WebpackOptions.json
@@ -123,6 +123,9 @@
               {
                 "type": "object"
               },
+              {
+                "$ref": "#/definitions/common.arrayOfStringValues"
+              },
               {
                 "type": "boolean"
               }

diff --git a/test/configCases/externals/optional-externals-array/index.js b/test/configCases/externals/optional-externals-array/index.js
@@ -0,0 +1,10 @@
+it("should not fail on optional externals", function() {
+	try {
+		require("external");
+	} catch(e) {
+		expect(e).toBeInstanceOf(Error);
+		expect(e.code).toBe("MODULE_NOT_FOUND");
+		return;
+	}
+	throw new Error("It doesn't fail");
+});
diff --git a/test/configCases/externals/optional-externals-array/webpack.config.js b/test/configCases/externals/optional-externals-array/webpack.config.js
@@ -0,0 +1,5 @@
+module.exports = {
+	externals: {
+		external: ["./math", "subtract"]
+	}
+};