Skip to content

Commit

Permalink
add todo for ModuleConcatenationPlugin for loop bugfix
Browse files Browse the repository at this point in the history
  • Loading branch information
brentwilton committed Mar 2, 2018
1 parent 9f37b49 commit 39095ef
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions lib/optimize/ModuleConcatenationPlugin.js
Expand Up @@ -281,6 +281,10 @@ class ModuleConcatenationPlugin {
for (const reason of newModule.reasons) {
reason.dependency.module = newModule;
}
// TODO: remove when LTS node version contains fixed v8 version
// @see https://github.com/webpack/webpack/pull/6613
// Turbofan does not correctly inline for-of loops with polymorphic input arrays.
// Work around issue by using a standard for loop and assigning dep.module.reasons
for (let i = 0; i < newModule.dependencies.length; i++) {
let dep = newModule.dependencies[i];
if (dep.module) {
Expand Down

0 comments on commit 39095ef

Please sign in to comment.