Merge pull request #9128 from rchl/fix/useful-chunk-load-stacktrace

fix: provide useful stacktrace on chunk loading failure
webpack · May 20, 2019 · 36c7ab7 · 36c7ab7
2 parents a145bea + b322070
commit 36c7ab7
Show file tree

Hide file tree

Showing 2 changed files with 62 additions and 60 deletions.
diff --git a/lib/web/JsonpMainTemplatePlugin.js b/lib/web/JsonpMainTemplatePlugin.js
@@ -173,6 +173,8 @@ class JsonpMainTemplatePlugin {
 								"}"
 						  ])
 						: "",
+					"// create error before stack unwound to get useful stacktrace later",
+					"var error = new Error();",
 					"onScriptComplete = function (event) {",
 					Template.indent([
 						"// avoid mem leaks in IE.",
@@ -185,7 +187,7 @@ class JsonpMainTemplatePlugin {
 							Template.indent([
 								"var errorType = event && (event.type === 'load' ? 'missing' : event.type);",
 								"var realSrc = event && event.target && event.target.src;",
-								"var error = new Error('Loading chunk ' + chunkId + ' failed.\\n(' + errorType + ': ' + realSrc + ')');",
+								"error.message = 'Loading chunk ' + chunkId + ' failed.\\n(' + errorType + ': ' + realSrc + ')';",
 								"error.type = errorType;",
 								"error.request = realSrc;",
 								"chunk[1](error);"