Memoize NormalModule.size()

webpack · Sep 20, 2019 · 2aef0b6 · 2aef0b6
1 parent b07d3b6
commit 2aef0b6
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/lib/NormalModule.js b/lib/NormalModule.js
@@ -87,6 +87,7 @@ class NormalModule extends Module {
 		// Info from Build
 		this.error = null;
 		this._source = null;
+		this._sourceSize = null;
 		this._buildHash = "";
 		this.buildTimestamp = undefined;
 		/** @private @type {Map<string, CachedSourceEntry>} */
@@ -347,6 +348,7 @@ class NormalModule extends Module {
 					resourceBuffer,
 					sourceMap
 				);
+				this._sourceSize = null;
 				this._ast =
 					typeof extraInfo === "object" &&
 					extraInfo !== null &&
@@ -366,6 +368,7 @@ class NormalModule extends Module {
 		this._source = new RawSource(
 			"throw new Error(" + JSON.stringify(this.error.message) + ");"
 		);
+		this._sourceSize = null;
 		this._ast = null;
 	}
 
@@ -425,6 +428,7 @@ class NormalModule extends Module {
 		this.buildTimestamp = Date.now();
 		this.built = true;
 		this._source = null;
+		this._sourceSize = null;
 		this._ast = null;
 		this._buildHash = "";
 		this.error = null;
@@ -559,7 +563,10 @@ class NormalModule extends Module {
 	}
 
 	size() {
-		return this._source ? this._source.size() : -1;
+		if (this._sourceSize === null) {
+			this._sourceSize = this._source ? this._source.size() : -1;
+		}
+		return this._sourceSize;
 	}
 
 	/**