Merge pull request #8266 from ljqx/wasm-finalize-exports-fix

[WasmFinalizeExportsPlugin] check if `ref` is null before using it
webpack · Oct 24, 2018 · 298fa4c · 298fa4c
2 parents 735b4aa + 035ceb6
commit 298fa4c
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 0 deletions.
diff --git a/lib/wasm/WasmFinalizeExportsPlugin.js b/lib/wasm/WasmFinalizeExportsPlugin.js
@@ -30,6 +30,8 @@ class WasmFinalizeExportsPlugin {
 										reason.dependency
 									);
 
+									if (!ref) continue;
+
 									const importedNames = ref.importedNames;
 
 									if (Array.isArray(importedNames)) {

diff --git a/test/cases/wasm/finalize-exports-issue-8261/index.js b/test/cases/wasm/finalize-exports-issue-8261/index.js
@@ -0,0 +1,3 @@
+it("should not throw when no dependency reference", function() {
+	return expect(() => import("side-effect-free")).not.toThrow();
+});
diff --git a/test/cases/wasm/finalize-exports-issue-8261/node_modules/side-effect-free/index.js b/test/cases/wasm/finalize-exports-issue-8261/node_modules/side-effect-free/index.js
diff --git a/test/cases/wasm/finalize-exports-issue-8261/node_modules/side-effect-free/module.wat b/test/cases/wasm/finalize-exports-issue-8261/node_modules/side-effect-free/module.wat
diff --git a/test/cases/wasm/finalize-exports-issue-8261/node_modules/side-effect-free/package.json b/test/cases/wasm/finalize-exports-issue-8261/node_modules/side-effect-free/package.json
diff --git a/test/cases/wasm/finalize-exports-issue-8261/test.filter.js b/test/cases/wasm/finalize-exports-issue-8261/test.filter.js
@@ -0,0 +1,5 @@
+var supportsWebAssembly = require("../../../helpers/supportsWebAssembly");
+
+module.exports = function(config) {
+	return supportsWebAssembly();
+};