Skip to content

Commit

Permalink
Merge pull request #7694 from webpack/bugfix/loc-in-context
Browse files Browse the repository at this point in the history
make loc in context dependencies a correct object
  • Loading branch information
sokra committed Jul 10, 2018
2 parents 78d8f4a + 79846d1 commit 1869d8e
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 2 deletions.
21 changes: 20 additions & 1 deletion lib/ContextModule.js
Expand Up @@ -12,11 +12,28 @@ const contextify = require("./util/identifier").contextify;

/** @typedef {import("./dependencies/ContextElementDependency")} ContextElementDependency */

/**
* @callback ResolveDependenciesCallback
* @param {Error=} err
* @param {ContextElementDependency[]} dependencies
*/

/**
* @callback ResolveDependencies
* @param {TODO} fs
* @param {TODO} options
* @param {ResolveDependenciesCallback} callback
*/

class ContextModule extends Module {
// type ContextMode = "sync" | "eager" | "weak" | "async-weak" | "lazy" | "lazy-once"
// type ContextOptions = { resource: string, recursive: boolean, regExp: RegExp, addon?: string, mode?: ContextMode, chunkName?: string, include?: RegExp, exclude?: RegExp, groupOptions?: Object }
// resolveDependencies: (fs: FS, options: ContextOptions, (err: Error?, dependencies: Dependency[]) => void) => void
// options: ContextOptions
/**
* @param {ResolveDependencies} resolveDependencies function to get dependencies in this context
* @param {TODO} options options object
*/
constructor(resolveDependencies, options) {
let resource;
let resourceQuery;
Expand Down Expand Up @@ -194,7 +211,9 @@ class ContextModule extends Module {

// enhance dependencies with meta info
for (const dep of dependencies) {
dep.loc = dep.userRequest;
dep.loc = {
name: dep.userRequest
};
dep.request = this.options.addon + dep.request;
}

Expand Down
2 changes: 1 addition & 1 deletion lib/Dependency.js
Expand Up @@ -30,7 +30,7 @@ const DependencyReference = require("./dependencies/DependencyReference");

/** @typedef {Object} SynteticDependencyLocation
* @property {string} name
* @property {number} index
* @property {number=} index
*/

/** @typedef {SynteticDependencyLocation|RealDependencyLocation} DependencyLocation */
Expand Down

0 comments on commit 1869d8e

Please sign in to comment.