Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor e2e tests to playwright #5080

Draft
wants to merge 72 commits into
base: master
Choose a base branch
from
Draft

chore: refactor e2e tests to playwright #5080

wants to merge 72 commits into from
+3,621 −2,195

Conversation

mahdikhashan
Copy link

WIP: will refactors tests one by one and rename the e2e-playwright folder to e2e after its done

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

It will introduce playwright in the project to replace the existing puppeteer end to end framework.

Breaking Changes

Additional Info

@mahdikhashan
chore: setup playwright
13c06af 
WIP: will refactors tests one by one and rename the e2e-playwright folder to e2e after its done
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Mar 1, 2024 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

@mahdikhashan mahdikhashan changed the title chore: setup playwright chore: refactor e2e tests to playwright Mar 1, 2024
mahdikhashan and others added 6 commits March 1, 2024 12:29
@mahdikhashan
chore: disable parallel test running
18e0e30
@mahdikhashan
feat: remove example test from playwright setup step
91ad989
@mahdikhashan
test: refactor test/e2e/states.test.js
2f97665 
WIP: will rename the test and clean it up after i received a feedback from maintainers
@dependabot
chore(deps): bump html-entities from 2.4.0 to 2.5.0 (webpack#5083)
5f44a78 
Bumps [html-entities](https://github.com/mdevils/html-entities) from 2.4.0 to 2.5.0.
- [Release notes](https://github.com/mdevils/html-entities/releases)
- [Changelog](https://github.com/mdevils/html-entities/blob/master/CHANGELOG.md)
- [Commits](mdevils/html-entities@v2.4.0...v2.5.0)

---
updated-dependencies:
- dependency-name: html-entities
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump cspell from 8.4.1 to 8.5.0 (webpack#5082)
1c20920 
Bumps [cspell](https://github.com/streetsidesoftware/cspell) from 8.4.1 to 8.5.0.
- [Release notes](https://github.com/streetsidesoftware/cspell/releases)
- [Changelog](https://github.com/streetsidesoftware/cspell/blob/main/CHANGELOG.md)
- [Commits](streetsidesoftware/cspell@v8.4.1...v8.5.0)

---
updated-dependencies:
- dependency-name: cspell
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump express from 4.18.2 to 4.18.3 (webpack#5078)
d58d557 
Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.18.3.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.18.2...4.18.3)

---
updated-dependencies:
- dependency-name: express
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
alexander-akait
alexander-akait reviewed Mar 4, 2024
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we need to rewrite existing tests on playwright + some refactor our tests, because we have a lot of code duplication

@mahdikhashan
Copy link
Author

mahdikhashan commented Mar 4, 2024 •
edited

@alexander-akait thanks for your comment, for participating in the gsoc-2024, is this PR a valid patch requirements? if not could you introduce an issue which I can start working on? I'm a master student and a junior developer. regarding the proposal, is there anything specific things to be mentioned on or do you have a template from the previous years? also, if there is a discord of slack channel which I can share the draft version of proposal and receive early feedback, I appreciate it.

@alexander-akait
Copy link
Member

/cc @evenstensberg

dependabot bot added 2 commits March 4, 2024 15:52
@dependabot
chore(deps-dev): bump @types/node from 20.11.22 to 20.11.24 (webpack#…
3790bec 
…5079)

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.11.22 to 20.11.24.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump @babel/preset-env from 7.23.9 to 7.24.0 (webpac…
cddf382 
…k#5075)

Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.23.9 to 7.24.0.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.24.0/packages/babel-preset-env)

---
updated-dependencies:
- dependency-name: "@babel/preset-env"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@evenstensberg
Copy link
Member

I think this should work for a gsoc project. (90h project)

@snitin315
Copy link
Member

I think this should work for a gsoc project. (90h project)

Yes, I agree.

dependabot bot and others added 14 commits March 5, 2024 13:55
@dependabot
chore(deps): bump html-entities from 2.5.0 to 2.5.2 (webpack#5087)
1e97fe0 
Bumps [html-entities](https://github.com/mdevils/html-entities) from 2.5.0 to 2.5.2.
- [Release notes](https://github.com/mdevils/html-entities/releases)
- [Changelog](https://github.com/mdevils/html-entities/blob/master/CHANGELOG.md)
- [Commits](mdevils/html-entities@v2.5.0...v2.5.2)

---
updated-dependencies:
- dependency-name: html-entities
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ayushkumarbhadani
refactor: add 'mode' property in second array object in examples (web…
2aed762 
…pack#5086)
@alexander-akait
docs: fix migration guide (webpack#5089)
71e5e9f
@dependabot
chore(deps-dev): bump puppeteer from 22.3.0 to 22.4.0 (webpack#5090)
a8cdccd 
Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 22.3.0 to 22.4.0.
- [Release notes](https://github.com/puppeteer/puppeteer/releases)
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json)
- [Commits](puppeteer/puppeteer@puppeteer-v22.3.0...puppeteer-v22.4.0)

---
updated-dependencies:
- dependency-name: puppeteer
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump cspell from 8.5.0 to 8.6.0 (webpack#5091)
53de75d 
Bumps [cspell](https://github.com/streetsidesoftware/cspell) from 8.5.0 to 8.6.0.
- [Release notes](https://github.com/streetsidesoftware/cspell/releases)
- [Changelog](https://github.com/streetsidesoftware/cspell/blob/main/CHANGELOG.md)
- [Commits](streetsidesoftware/cspell@v8.5.0...v8.6.0)

---
updated-dependencies:
- dependency-name: cspell
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@alexander-akait
chore(deps): update (webpack#5096)
2201442
@dependabot
chore(deps-dev): bump puppeteer from 22.4.0 to 22.4.1 (webpack#5099)
c6a3586 
Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 22.4.0 to 22.4.1.
- [Release notes](https://github.com/puppeteer/puppeteer/releases)
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json)
- [Commits](puppeteer/puppeteer@puppeteer-v22.4.0...puppeteer-v22.4.1)

---
updated-dependencies:
- dependency-name: puppeteer
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump open from 10.0.4 to 10.1.0 (webpack#5100)
8ea7cb8 
Bumps [open](https://github.com/sindresorhus/open) from 10.0.4 to 10.1.0.
- [Release notes](https://github.com/sindresorhus/open/releases)
- [Commits](sindresorhus/open@v10.0.4...v10.1.0)

---
updated-dependencies:
- dependency-name: open
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@alexander-akait
fix(types): proxy (webpack#5101)
6e1aed3
@dependabot
chore(deps-dev): bump @types/node from 20.11.25 to 20.11.26 (webpack#…
37f4760 
…5102)

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.11.25 to 20.11.26.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@alexander-akait
chore(release): 5.0.3
08cab58
@dependabot
chore(deps-dev): bump @commitlint/cli from 19.0.3 to 19.1.0 (webpack#…
ba9dfb6 
…5103)

Bumps [@commitlint/cli](https://github.com/conventional-changelog/commitlint/tree/HEAD/@commitlint/cli) from 19.0.3 to 19.1.0.
- [Release notes](https://github.com/conventional-changelog/commitlint/releases)
- [Changelog](https://github.com/conventional-changelog/commitlint/blob/master/@commitlint/cli/CHANGELOG.md)
- [Commits](https://github.com/conventional-changelog/commitlint/commits/v19.1.0/@commitlint/cli)

---
updated-dependencies:
- dependency-name: "@commitlint/cli"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump @commitlint/config-conventional (webpack#5104)
fb6f22a 
Bumps [@commitlint/config-conventional](https://github.com/conventional-changelog/commitlint/tree/HEAD/@commitlint/config-conventional) from 19.0.3 to 19.1.0.
- [Release notes](https://github.com/conventional-changelog/commitlint/releases)
- [Changelog](https://github.com/conventional-changelog/commitlint/blob/master/@commitlint/config-conventional/CHANGELOG.md)
- [Commits](https://github.com/conventional-changelog/commitlint/commits/v19.1.0/@commitlint/config-conventional)

---
updated-dependencies:
- dependency-name: "@commitlint/config-conventional"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@alexander-akait
fix(security): bump webpack-dev-middleware (webpack#5112)
aab576a
dependabot bot and others added 24 commits April 4, 2024 13:21
@dependabot
chore(deps-dev): bump css-loader from 6.10.0 to 6.11.0 (webpack#5139)
760657d 
Bumps [css-loader](https://github.com/webpack-contrib/css-loader) from 6.10.0 to 6.11.0.
- [Release notes](https://github.com/webpack-contrib/css-loader/releases)
- [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md)
- [Commits](webpack-contrib/css-loader@v6.10.0...v6.11.0)

---
updated-dependencies:
- dependency-name: css-loader
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump @types/node from 20.12.3 to 20.12.4 (webpack#5137)
f3788a0 
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.12.3 to 20.12.4.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump @babel/preset-env from 7.24.3 to 7.24.4 (webpac…
9fddbb9 
…k#5135)

Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.24.3 to 7.24.4.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.24.4/packages/babel-preset-env)

---
updated-dependencies:
- dependency-name: "@babel/preset-env"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump @types/node from 20.12.4 to 20.12.5 (webpack#5144)
c5aa7aa 
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.12.4 to 20.12.5.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump @types/node from 20.12.5 to 20.12.7 (webpack#5146)
b318063 
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.12.5 to 20.12.7.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@codingwithbenny
chore: upgrading express from version 4.17.3 to version 4.19.2 due to…
767b493 
… vulnerability CVE-2024-29041 (webpack#5134)
@dependabot
chore(deps-dev): bump cspell from 8.6.1 to 8.7.0 (webpack#5148)
7c42ea0 
Bumps [cspell](https://github.com/streetsidesoftware/cspell/tree/HEAD/packages/cspell) from 8.6.1 to 8.7.0.
- [Release notes](https://github.com/streetsidesoftware/cspell/releases)
- [Changelog](https://github.com/streetsidesoftware/cspell/blob/main/packages/cspell/CHANGELOG.md)
- [Commits](https://github.com/streetsidesoftware/cspell/commits/v8.7.0/packages/cspell)

---
updated-dependencies:
- dependency-name: cspell
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump @commitlint/cli from 19.2.1 to 19.2.2 (webpack#…
f661407 
…5151)

Bumps [@commitlint/cli](https://github.com/conventional-changelog/commitlint/tree/HEAD/@commitlint/cli) from 19.2.1 to 19.2.2.
- [Release notes](https://github.com/conventional-changelog/commitlint/releases)
- [Changelog](https://github.com/conventional-changelog/commitlint/blob/master/@commitlint/cli/CHANGELOG.md)
- [Commits](https://github.com/conventional-changelog/commitlint/commits/v19.2.2/@commitlint/cli)

---
updated-dependencies:
- dependency-name: "@commitlint/cli"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump memfs from 4.8.1 to 4.8.2 (webpack#5152)
1a81676 
Bumps [memfs](https://github.com/streamich/memfs) from 4.8.1 to 4.8.2.
- [Release notes](https://github.com/streamich/memfs/releases)
- [Changelog](https://github.com/streamich/memfs/blob/master/CHANGELOG.md)
- [Commits](streamich/memfs@v4.8.1...v4.8.2)

---
updated-dependencies:
- dependency-name: memfs
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump @babel/core from 7.24.3 to 7.24.4 (webpack#5136)
31d9d77 
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.24.3 to 7.24.4.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.24.4/packages/babel-core)

---
updated-dependencies:
- dependency-name: "@babel/core"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump marked from 12.0.1 to 12.0.2 (webpack#5160)
5c8544c 
Bumps [marked](https://github.com/markedjs/marked) from 12.0.1 to 12.0.2.
- [Release notes](https://github.com/markedjs/marked/releases)
- [Changelog](https://github.com/markedjs/marked/blob/master/.releaserc.json)
- [Commits](markedjs/marked@v12.0.1...v12.0.2)

---
updated-dependencies:
- dependency-name: marked
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump core-js from 3.36.1 to 3.37.0 (webpack#5155)
c9f3bd4 
Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js) from 3.36.1 to 3.37.0.
- [Release notes](https://github.com/zloirock/core-js/releases)
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/zloirock/core-js/commits/v3.37.0/packages/core-js)

---
updated-dependencies:
- dependency-name: core-js
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump @babel/runtime from 7.24.1 to 7.24.4 (webpack#5138
d1fcc72 
)

Bumps [@babel/runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-runtime) from 7.24.1 to 7.24.4.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.24.4/packages/babel-runtime)

---
updated-dependencies:
- dependency-name: "@babel/runtime"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump ipaddr.js from 2.1.0 to 2.2.0 (webpack#5159)
be8a832 
Bumps [ipaddr.js](https://github.com/whitequark/ipaddr.js) from 2.1.0 to 2.2.0.
- [Changelog](https://github.com/whitequark/ipaddr.js/blob/main/Changes.md)
- [Commits](whitequark/ipaddr.js@v2.1.0...v2.2.0)

---
updated-dependencies:
- dependency-name: ipaddr.js
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@askoufis
fix: replace rimraf with rm (webpack#5162)
1a1561f
@alexander-akait
feat: added the app option to setup any connect compatibility HTT…
3096148 
…P server framework
@snitin315
ci: add Node v22 (webpack#5164)
a3ced4d
@mahdikhashan
chore: setup playwright
69e21f1 
WIP: will refactors tests one by one and rename the e2e-playwright folder to e2e after its done
@mahdikhashan
chore: disable parallel test running
9a1b7e7
@mahdikhashan
feat: remove example test from playwright setup step
e690789
@mahdikhashan
test: refactor test/e2e/states.test.js
f371ae6 
WIP: will rename the test and clean it up after i received a feedback from maintainers
@mahdikhashan
Merge remote-tracking branch 'origin/issue-2843/refactor-e2e-tests-fr…
8c663b0 
…om-puppeter-to-playwright' into issue-2843/refactor-e2e-tests-from-puppeter-to-playwright

# Conflicts:
#	package-lock.json
#	package.json
@mahdikhashan
chore: add playwright after it was removed by merge conflicts
e0cdf7d
@mahdikhashan
chore: initial config for playwright
8f5fdac
evenstensberg
evenstensberg reviewed May 12, 2024
View reviewed changes
playwright.config.js Outdated
testDir: "./test/e2e-playwright",
fullyParallel: true,
forbidOnly: !!process.env.CI,
retries: process.env.CI ? 2 : 0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make the CI env a const variable instead

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait left review comments

@evenstensberg evenstensberg evenstensberg left review comments

@hiroppy hiroppy Awaiting requested review from hiroppy hiroppy will be requested when the pull request is marked ready for review hiroppy is a code owner

@snitin315 snitin315 Awaiting requested review from snitin315 snitin315 will be requested when the pull request is marked ready for review snitin315 is a code owner

@anshumanv anshumanv Awaiting requested review from anshumanv anshumanv will be requested when the pull request is marked ready for review anshumanv is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mahdikhashan @alexander-akait @evenstensberg @snitin315 @ayushkumarbhadani @codingwithbenny @askoufis