fix: show warning for non-web targets

webpack · Mar 19, 2021 · 43fca8f · 43fca8f
1 parent 728effc
commit 43fca8f
Show file tree

Hide file tree

Showing 4 changed files with 40 additions and 14 deletions.
diff --git a/lib/Server.js b/lib/Server.js
@@ -33,6 +33,7 @@ const getColorsOption = require('./utils/getColorsOption');
 const setupExitSignals = require('./utils/setupExitSignals');
 const findPort = require('./utils/findPort');
 const schema = require('./options.json');
+const isWebTarget = require('./utils/isWebTarget');
 
 if (!process.env.WEBPACK_SERVE) {
   process.env.WEBPACK_SERVE = true;
@@ -662,6 +663,13 @@ class Server {
       );
     }
 
+    if (!isWebTarget(this.compiler.options)) {
+      this.logger.info(`A non-web target was selected in dev server config.`);
+      if (this.options.liveReload) {
+        this.logger.info(`Live reload will not work with a non-web target.`);
+      }
+    }
+
     if (this.options.open || this.options.openPage) {
       runOpen(localUrlForTerminal, this.options, this.logger);
     }

diff --git a/lib/utils/DevServerPlugin.js b/lib/utils/DevServerPlugin.js
@@ -3,6 +3,7 @@
 const webpack = require('webpack');
 const createDomain = require('./createDomain');
 const getSocketClientPath = require('./getSocketClientPath');
+const isWebTarget = require('./isWebTarget');
 
 // @ts-ignore
 const EntryPlugin = webpack.EntryPlugin;
@@ -137,24 +138,11 @@ class DevServerPlugin {
 
     compilerOptions.plugins = compilerOptions.plugins || [];
 
-    /** @type {boolean} */
-    const isWebTarget = compilerOptions.externalsPresets
-      ? compilerOptions.externalsPresets.web
-      : [
-          'web',
-          'webworker',
-          'electron-renderer',
-          'node-webkit',
-          // eslint-disable-next-line no-undefined
-          undefined,
-          null,
-        ].includes(compilerOptions.target);
-
     /** @type {Entry} */
     const additionalEntries = checkInject(
       options.injectClient,
       compilerOptions,
-      isWebTarget
+      isWebTarget(compilerOptions)
     )
       ? [clientEntry]
       : [];

diff --git a/lib/utils/isWebTarget.js b/lib/utils/isWebTarget.js
@@ -0,0 +1,16 @@
+'use strict';
+
+const isWebTarget = (compilerOptions) =>
+  compilerOptions.externalsPresets
+    ? compilerOptions.externalsPresets.web
+    : [
+        'web',
+        'webworker',
+        'electron-renderer',
+        'node-webkit',
+        // eslint-disable-next-line no-undefined
+        undefined,
+        null,
+      ].includes(compilerOptions.target);
+
+module.exports = isWebTarget;
diff --git a/test/cli/cli.test.js b/test/cli/cli.test.js
@@ -165,6 +165,20 @@ describe('CLI', () => {
       });
   });
 
+  it('should show a warning for live reloading with non-web target', (done) => {
+    testBin('--target node --live-reload')
+      .then((output) => {
+        expect(output.stderr).toContain(
+          'A non-web target was selected in dev server config'
+        );
+        expect(output.stderr).toContain(
+          'Live reload will not work with a non-web target'
+        );
+        done();
+      })
+      .catch(done);
+  });
+
   it('should log static', (done) => {
     testBin(
       '--no-color',