Add NoEmitOnErrorsPlugin transformation (#399)

* ast(migrate): handle no emit on error

* ast(migrate): handle module concatenation and named modules

* ast(migrate): handle module concatenation and named modules

lib/migrate/index.js

@@ -9,6 +9,7 @@ const uglifyJsPluginTransform = require("./uglifyJsPlugin/uglifyJsPlugin");
 const loaderOptionsPluginTransform = require("./loaderOptionsPlugin/loaderOptionsPlugin");
 const bannerPluginTransform = require("./bannerPlugin/bannerPlugin");
 const extractTextPluginTransform = require("./extractTextPlugin/extractTextPlugin");
+const noEmitOnErrorsPluginTransform = require("./noEmitOnErrorsPlugin/noEmitOnErrorsPlugin");
 const removeDeprecatedPluginsTransform = require("./removeDeprecatedPlugins/removeDeprecatedPlugins");
 
 const transformsObject = {
@@ -19,6 +20,7 @@ const transformsObject = {
 	loaderOptionsPluginTransform,
 	bannerPluginTransform,
 	extractTextPluginTransform,
+	noEmitOnErrorsPluginTransform,
 	removeDeprecatedPluginsTransform
 };
 

lib/migrate/moduleConcatenationPlugin/__snapshots__/moduleConcatenationPlugin.test.js.snap

@@ -0,0 +1,31 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`moduleConcatenationPlugin transforms correctly using "moduleConcatenationPlugin-0" data 1`] = `
+"module.export = {
+    optimizations: {
+        concatenateModules: true
+    }
+}
+"
+`;
+
+exports[`moduleConcatenationPlugin transforms correctly using "moduleConcatenationPlugin-1" data 1`] = `
+"module.export = {
+	optimizations: {
+        splitChunks: false,
+        concatenateModules: true
+    },
+    plugins: [new Foo()]
+}
+"
+`;
+
+exports[`moduleConcatenationPlugin transforms correctly using "moduleConcatenationPlugin-2" data 1`] = `
+"module.export = {
+	optimizations: {
+        concatenateModules: true
+    },
+    plugins: [new Foo()]
+}
+"
+`;

lib/migrate/moduleConcatenationPlugin/__testfixtures__/.editorconfig

@@ -0,0 +1,3 @@
+[*]
+indent_style = space
+indent_size = 4

lib/migrate/moduleConcatenationPlugin/__testfixtures__/moduleConcatenationPlugin-0.input.js

@@ -0,0 +1,5 @@
+module.export = {
+    plugins: [
+        new webpack.optimize.ModuleConcatenationPlugin()
+    ]
+}

lib/migrate/moduleConcatenationPlugin/__testfixtures__/moduleConcatenationPlugin-1.input.js

@@ -0,0 +1,9 @@
+module.export = {
+	optimizations: {
+		splitChunks: false
+	},
+    plugins: [
+        new Foo(),
+        new webpack.optimize.ModuleConcatenationPlugin()
+    ]
+}

lib/migrate/moduleConcatenationPlugin/__testfixtures__/moduleConcatenationPlugin-2.input.js

@@ -0,0 +1,9 @@
+module.export = {
+	optimizations: {
+		concatenateModules: false
+	},
+    plugins: [
+        new Foo(),
+        new webpack.optimize.ModuleConcatenationPlugin()
+    ]
+}

lib/migrate/moduleConcatenationPlugin/moduleConcatenationPlugin.js

@@ -0,0 +1,34 @@
+const {
+	addOrUpdateConfigObject,
+	findAndRemovePluginByName
+} = require("../../utils/ast-utils");
+
+/**
+ *
+ * Transform for NamedModulesPlugin. If found, removes the
+ * plugin and sets optimizations.namedModules to true
+ *
+ * @param {Object} j - jscodeshift top-level import
+ * @param {Node} ast - jscodeshift ast to transform
+ * @returns {Node} ast - jscodeshift ast
+ */
+module.exports = function(j, ast) {
+	// Remove old plugin
+	const root = findAndRemovePluginByName(
+		j,
+		ast,
+		"webpack.optimize.ModuleConcatenationPlugin"
+	);
+
+	// Add new optimizations option
+	root &&
+		addOrUpdateConfigObject(
+			j,
+			root,
+			"optimizations",
+			"concatenateModules",
+			j.booleanLiteral(true)
+		);
+
+	return ast;
+};

lib/migrate/moduleConcatenationPlugin/moduleConcatenationPlugin.test.js

@@ -0,0 +1,19 @@
+"use strict";
+
+const defineTest = require("../../utils/defineTest");
+
+defineTest(
+	__dirname,
+	"moduleConcatenationPlugin",
+	"moduleConcatenationPlugin-0"
+);
+defineTest(
+	__dirname,
+	"moduleConcatenationPlugin",
+	"moduleConcatenationPlugin-1"
+);
+defineTest(
+	__dirname,
+	"moduleConcatenationPlugin",
+	"moduleConcatenationPlugin-2"
+);

lib/migrate/namedModulesPlugin/__snapshots__/namedModulesPlugin.test.js.snap

@@ -0,0 +1,31 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`namedModulesPlugin transforms correctly using "namedModulesPlugin-0" data 1`] = `
+"module.export = {
+    optimizations: {
+        namedModules: true
+    }
+}
+"
+`;
+
+exports[`namedModulesPlugin transforms correctly using "namedModulesPlugin-1" data 1`] = `
+"module.export = {
+	optimizations: {
+        splitChunks: false,
+        namedModules: true
+    },
+    plugins: [new Foo()]
+}
+"
+`;
+
+exports[`namedModulesPlugin transforms correctly using "namedModulesPlugin-2" data 1`] = `
+"module.export = {
+	optimizations: {
+        namedModules: true
+    },
+    plugins: [new Foo()]
+}
+"
+`;

lib/migrate/namedModulesPlugin/__testfixtures__/.editorconfig

@@ -0,0 +1,3 @@
+[*]
+indent_style = space
+indent_size = 4

lib/migrate/namedModulesPlugin/__testfixtures__/namedModulesPlugin-0.input.js

@@ -0,0 +1,5 @@
+module.export = {
+    plugins: [
+        new webpack.NamedModulesPlugin()
+    ]
+}

lib/migrate/namedModulesPlugin/__testfixtures__/namedModulesPlugin-1.input.js

@@ -0,0 +1,9 @@
+module.export = {
+	optimizations: {
+		splitChunks: false
+	},
+    plugins: [
+        new Foo(),
+        new webpack.NamedModulesPlugin()
+    ]
+}

lib/migrate/namedModulesPlugin/__testfixtures__/namedModulesPlugin-2.input.js

@@ -0,0 +1,9 @@
+module.export = {
+	optimizations: {
+		namedModules: false
+	},
+    plugins: [
+        new Foo(),
+        new webpack.NamedModulesPlugin()
+    ]
+}

lib/migrate/namedModulesPlugin/namedModulesPlugin.js

@@ -0,0 +1,30 @@
+const {
+	addOrUpdateConfigObject,
+	findAndRemovePluginByName
+} = require("../../utils/ast-utils");
+
+/**
+ *
+ * Transform for NamedModulesPlugin. If found, removes the
+ * plugin and sets optimizations.namedModules to true
+ *
+ * @param {Object} j - jscodeshift top-level import
+ * @param {Node} ast - jscodeshift ast to transform
+ * @returns {Node} ast - jscodeshift ast
+ */
+module.exports = function(j, ast) {
+	// Remove old plugin
+	const root = findAndRemovePluginByName(j, ast, "webpack.NamedModulesPlugin");
+
+	// Add new optimizations option
+	root &&
+		addOrUpdateConfigObject(
+			j,
+			root,
+			"optimizations",
+			"namedModules",
+			j.booleanLiteral(true)
+		);
+
+	return ast;
+};

lib/migrate/namedModulesPlugin/namedModulesPlugin.test.js

@@ -0,0 +1,7 @@
+"use strict";
+
+const defineTest = require("../../utils/defineTest");
+
+defineTest(__dirname, "namedModulesPlugin", "namedModulesPlugin-0");
+defineTest(__dirname, "namedModulesPlugin", "namedModulesPlugin-1");
+defineTest(__dirname, "namedModulesPlugin", "namedModulesPlugin-2");

lib/migrate/noEmitOnErrorsPlugin/__snapshots__/noEmitOnErrorsPlugin.test.js.snap

@@ -0,0 +1,31 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`noEmitOnErrorsPlugin transforms correctly using "noEmitOnErrorsPlugin-0" data 1`] = `
+"module.export = {
+    optimizations: {
+        noEmitOnErrors: true
+    }
+}
+"
+`;
+
+exports[`noEmitOnErrorsPlugin transforms correctly using "noEmitOnErrorsPlugin-1" data 1`] = `
+"module.export = {
+	optimizations: {
+        splitChunks: false,
+        noEmitOnErrors: true
+    },
+    plugins: [new Foo()]
+}
+"
+`;
+
+exports[`noEmitOnErrorsPlugin transforms correctly using "noEmitOnErrorsPlugin-2" data 1`] = `
+"module.export = {
+	optimizations: {
+        noEmitOnErrors: true
+    },
+    plugins: [new Foo()]
+}
+"
+`;

lib/migrate/noEmitOnErrorsPlugin/__testfixtures__/.editorconfig

@@ -0,0 +1,3 @@
+[*]
+indent_style = space
+indent_size = 4

lib/migrate/noEmitOnErrorsPlugin/__testfixtures__/noEmitOnErrorsPlugin-0.input.js

@@ -0,0 +1,5 @@
+module.export = {
+    plugins: [
+        new webpack.NoEmitOnErrorsPlugin()
+    ]
+}

lib/migrate/noEmitOnErrorsPlugin/__testfixtures__/noEmitOnErrorsPlugin-1.input.js

@@ -0,0 +1,9 @@
+module.export = {
+	optimizations: {
+		splitChunks: false
+	},
+    plugins: [
+        new Foo(),
+        new webpack.NoEmitOnErrorsPlugin()
+    ]
+}

lib/migrate/noEmitOnErrorsPlugin/__testfixtures__/noEmitOnErrorsPlugin-2.input.js

@@ -0,0 +1,9 @@
+module.export = {
+	optimizations: {
+		noEmitOnErrors: false
+	},
+    plugins: [
+        new Foo(),
+        new webpack.NoEmitOnErrorsPlugin()
+    ]
+}

lib/migrate/noEmitOnErrorsPlugin/noEmitOnErrorsPlugin.js

@@ -0,0 +1,34 @@
+const {
+	addOrUpdateConfigObject,
+	findAndRemovePluginByName
+} = require("../../utils/ast-utils");
+
+/**
+ *
+ * Transform for NoEmitOnErrorsPlugin. If found, removes the
+ * plugin and sets optimizations.noEmitOnErrors to true
+ *
+ * @param {Object} j - jscodeshift top-level import
+ * @param {Node} ast - jscodeshift ast to transform
+ * @returns {Node} ast - jscodeshift ast
+ */
+module.exports = function(j, ast) {
+	// Remove old plugin
+	const root = findAndRemovePluginByName(
+		j,
+		ast,
+		"webpack.NoEmitOnErrorsPlugin"
+	);
+
+	// Add new optimizations option
+	root &&
+		addOrUpdateConfigObject(
+			j,
+			root,
+			"optimizations",
+			"noEmitOnErrors",
+			j.booleanLiteral(true)
+		);
+
+	return ast;
+};

lib/migrate/noEmitOnErrorsPlugin/noEmitOnErrorsPlugin.test.js

@@ -0,0 +1,7 @@
+"use strict";
+
+const defineTest = require("../../utils/defineTest");
+
+defineTest(__dirname, "noEmitOnErrorsPlugin", "noEmitOnErrorsPlugin-0");
+defineTest(__dirname, "noEmitOnErrorsPlugin", "noEmitOnErrorsPlugin-1");
+defineTest(__dirname, "noEmitOnErrorsPlugin", "noEmitOnErrorsPlugin-2");