fix(rules/imports): loose rules for import/extensions && import/no-unresolved (warn)
#7
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reasoning: All of our loaders / plugins require webpack, though most have either a loose or no dependency on it thus this rule will almost always fail.
- Reasoning: All of our loaders / plugins require webpack, though most have either a loose or no dependency on it thus this rule will almost always fail.
michael-ciniawsky
approved these changes
Apr 8, 2017
- Reasoning: Error confilicts directly with most loader logic
8 tasks
michael-ciniawsky
approved these changes
Apr 8, 2017
bebraw
approved these changes
Apr 9, 2017
|
When do you |
|
@jhnns - I was looking into that this morning. |
michael-ciniawsky
changed the title
import/extensions && import/no-unresolved (warn)
michael-ciniawsky
requested review from
michael-ciniawsky and
alexander-akait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
import/no-unresolved will fail as webpack/* doesn't exist as an explicitly installed dependency
import/extensions will fail for the same reason, extension can't be determined for something that isn't there.
This change won't effect Travis runs ( no warning thrown ) as we explicitly install webpack