Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Replace unmaintained npm-run-all with npm-run-all2 #905

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

seanpoulter
Copy link
Contributor

Proposed Changes

This PR builds on webdriverio/webdriverio#12628:

I noticed that this project is using npm-run-all still and not the maintained fork npm-run-all2. Here's a PR that fixes that.

@christian-bromann
Copy link
Member

Mhm 🤔 it seems like this repository doesn't like this upgrade:

/home/runner/work/selenium-standalone/selenium-standalone/node_modules/npm-run-all2/node_modules/minimatch/dist/commonjs/ast.js:86
    #fillNegs() {
             ^

SyntaxError: Unexpected token '('

@seanpoulter
Copy link
Contributor Author

Ah, yea, Node.js v12 and v14 don't have support for private methods with a #.

It's runs with v12 because that's what is in "engines". Can we drop support for everything outside of the maintenance period? The release docs say that'd be >=18.

@christian-bromann
Copy link
Member

Can we drop support for everything outside of the maintenance period? The release docs say that'd be >=18.

Yes, but this would require a new major semver release.

@seanpoulter
Copy link
Contributor Author

That's a good point Christian. I'll set this up so we can build with the LTS and the target Node 12.

@seanpoulter seanpoulter marked this pull request as draft April 20, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants