Skip to content

Commit

Permalink
Fix error with axios and proxies (#897)
Browse files Browse the repository at this point in the history
* Fix error with axios and proxies

* Update dependabot with axios remove

* Temporal consoles in test for debugging error

* Remove debugging console in test
  • Loading branch information
juancsch committed Apr 2, 2024
1 parent 6d56e17 commit 77e4c6b
Show file tree
Hide file tree
Showing 4 changed files with 44 additions and 154 deletions.
64 changes: 30 additions & 34 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -1,36 +1,32 @@
version: 2
updates:
- package-ecosystem: npm
directory: "/"
schedule:
interval: weekly
time: "11:00"
open-pull-requests-limit: 10
versioning-strategy: increase-if-necessary
ignore:
- dependency-name: "got"
update-types: ["version-update:semver-major"]
- dependency-name: "mocha"
update-types: ["version-update:semver-major"]
- dependency-name: "axios"
update-types: ["version-update:semver-major"]
- dependency-name: "husky"
update-types: ["version-update:semver-major"]
- dependency-name: "release-it"
update-types: ["version-update:semver-major"]
- dependency-name: "commander"
update-types: ["version-update:semver-major"]
- dependency-name: "eslint-plugin-prettier"
update-types: ["version-update:semver-major"]
- dependency-name: "eslint"
update-types: ["version-update:semver-major"]
- dependency-name: "execa"
update-types: ["version-update:semver-major"]
- dependency-name: "find-process"
update-types: ["version-update:semver-major"]
- dependency-name: "fkill"
update-types: ["version-update:semver-major"]
- dependency-name: "prettier"
update-types: ["version-update:semver-major"]


- package-ecosystem: npm
directory: "/"
schedule:
interval: weekly
time: "11:00"
open-pull-requests-limit: 10
versioning-strategy: increase-if-necessary
ignore:
- dependency-name: "got"
update-types: ["version-update:semver-major"]
- dependency-name: "mocha"
update-types: ["version-update:semver-major"]
- dependency-name: "husky"
update-types: ["version-update:semver-major"]
- dependency-name: "release-it"
update-types: ["version-update:semver-major"]
- dependency-name: "commander"
update-types: ["version-update:semver-major"]
- dependency-name: "eslint-plugin-prettier"
update-types: ["version-update:semver-major"]
- dependency-name: "eslint"
update-types: ["version-update:semver-major"]
- dependency-name: "execa"
update-types: ["version-update:semver-major"]
- dependency-name: "find-process"
update-types: ["version-update:semver-major"]
- dependency-name: "fkill"
update-types: ["version-update:semver-major"]
- dependency-name: "prettier"
update-types: ["version-update:semver-major"]
11 changes: 5 additions & 6 deletions lib/compute-download-urls.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ const {
getIeDriverArchitectureOld,
getFirefoxDriverArchitectureOld,
} = require('./platformDetection');
const { default: axios } = require('axios');

const urls = {
selenium: '%s/%s/selenium-server-standalone-%s.jar',
Expand Down Expand Up @@ -278,15 +277,15 @@ function resolveDownloadPath(platform, buildId) {
}

async function getLastChromedriverVersionFromMajor(version) {
const response = await axios({
const response = await got({
method: 'get',
url: 'https://googlechromelabs.github.io/chrome-for-testing/known-good-versions-with-downloads.json',
responseType: 'json',
headers: {
'Content-Type': 'application/json',
},
});
const versionsWithMajor = response.data.versions.filter(
const versionsWithMajor = response.body.versions.filter(
(f) =>
validateMajorVersionPrefix(f.version) === validateMajorVersionPrefix(version) && 'chromedriver' in f.downloads
);
Expand All @@ -300,18 +299,18 @@ async function getLastChromedriverVersionFromMajor(version) {
}

async function getLatestChromeVersion(possibleChanel) {
const response = await axios({
const response = await got({
method: 'get',
url: 'https://googlechromelabs.github.io/chrome-for-testing/last-known-good-versions.json',
responseType: 'json',
headers: {
'Content-Type': 'application/json',
},
});
const channel = Object.keys(response.data.channels).find((i) => i.toLowerCase() === possibleChanel.toLowerCase());
const channel = Object.keys(response.body.channels).find((i) => i.toLowerCase() === possibleChanel.toLowerCase());

try {
return response.data.channels[channel].version;
return response.body.channels[channel].version;
} catch (err) {
console.log();
throw new Error(`channel can't be - ${possibleChanel}, possible only Stable, Beta, Dev, Canary`);
Expand Down
122 changes: 9 additions & 113 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@
}
},
"dependencies": {
"axios": "^1.6.2",
"commander": "^8.3.0",
"cross-spawn": "^7.0.3",
"debug": "^4.3.1",
Expand Down

0 comments on commit 77e4c6b

Please sign in to comment.