fix inline-template crashing (fix #9361) #9365

Itisfilipe · 2019-01-24T13:35:29Z

What kind of change does this PR introduce? (check at least one)

Does this PR introduce a breaking change? (check one)

Yes
No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

It's submitted to the dev branch for v2.x (or to a previous version branch), not the master branch
When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
New/updated tests are included

If adding a new feature, the PR's description includes:

A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
The generator function for inline templates genInlineTemplate did not prevent the generation of code when an invalid template was being introduced.

The solution introduced is verifying the existence of the first child before checking for its type, this should prevent the application from crashing trying to access attributes in an undefined child variable.

closes #9361

How to Reproduce

Index HTML

<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <meta name="viewport" content="width=device-width,initial-scale=1.0">
    <title>Hello World!</title>
    <!-- This is a development version of Vue.js! -->
    <!-- <script src="https://cdn.jsdelivr.net/npm/vue/dist/vue.js"></script> -->
    <script src="./vue.js"></script>
    <script src="/main.js" type="module"></script>
  </head>
  <body>
    <div id="app"></div>
  </body>
</html>

JS code

// ### main.js ###
import App from "./App.js";

Vue.config.productionTip = false;

new Vue({
  render: h => h(App),
}).$mount(`#app`);


// ### App.js ###
var HelloWorld = {
  name: 'HelloWorld',
  template: `<div></div>`,
  props: {
    msg: String
  }
}

export default {
  name: 'App',
  components: {
    HelloWorld
  },
  template: `
    <div id="app">
      <div is="helloWorld" inline-template></div>
    </div>
  `,
};

Error with current implementation

Error with this fix

fix vuejs#9361

fix inline-template crashing (fix vuejs#9361)

2aae9a3

yyx990803 merged commit 55bfb94 into vuejs:dev Feb 4, 2019

yyx990803 mentioned this pull request Feb 4, 2019

fix(#9361): appear error when using inline-template with no children #9362

Closed

13 tasks

snyk-bot mentioned this pull request Aug 13, 2019

[Snyk] Upgrade vue from 2.5.17 to 2.6.10 devopsred/gaia#5

Open

snyk-bot mentioned this pull request Sep 12, 2019

[Snyk] Upgrade vue from 2.5.3 to 2.6.10 cbrightly/pump-and-dump#2

Open

tt9133github mentioned this pull request Sep 18, 2019

[Snyk] Upgrade vue from 2.5.13 to 2.6.10 tt9133github/snyktest#2

Open

snyk-bot mentioned this pull request Oct 26, 2019

[Snyk] Upgrade vue from 2.5.13 to 2.6.10 ajesse11x/ethereumbook#4

Open

snyk-bot mentioned this pull request Dec 5, 2019

[Snyk] Upgrade vue-template-compiler from 2.5.13 to 2.6.10 dyna-dot/bit-javascript#3

Open

Lostlover pushed a commit to Lostlover/vue that referenced this pull request Dec 10, 2019

fix(compiler): fix inline-template crashing (vuejs#9365)

53c4e19

fix vuejs#9361

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix inline-template crashing (fix #9361) #9365

fix inline-template crashing (fix #9361) #9365

Itisfilipe commented Jan 24, 2019 •

edited

fix inline-template crashing (fix #9361) #9365

fix inline-template crashing (fix #9361) #9365

Conversation

Itisfilipe commented Jan 24, 2019 • edited

How to Reproduce

Itisfilipe commented Jan 24, 2019 •

edited