Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decode single quotes in html attributes #9341

Merged
merged 1 commit into from Feb 4, 2019
Merged

Conversation

bughit
Copy link
Contributor

@bughit bughit commented Jan 18, 2019

pretty much everything in the ruby world, html escapes single quotes
https://github.com/ruby/ruby/blob/trunk/lib/cgi/util.rb#L30

so, for example, haml pre-processed vue templates will have single quotes escaped

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

pretty much everything in the ruby world, html escapes single quotes
https://github.com/ruby/ruby/blob/trunk/lib/cgi/util.rb#L30

so, for example, haml pre-processed vue templates will have single quotes escaped
@yyx990803 yyx990803 merged commit c27fe24 into vuejs:dev Feb 4, 2019
Lostlover pushed a commit to Lostlover/vue that referenced this pull request Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants