[feature] allow template to be function in vue-server-renderer #9324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please see #9205 for use case It's great for head management, and actually makes the Example of new feature: const { createBundleRenderer } = require("vue-server-renderer")
const renderer = createBundleRenderer(serverbundle, {
async template (result, context){
return `<!DOCTYPE html>
<html>
<head>
${ context.renderStyles() }
</head>
<body>
${result}
</body>
</html>`
}
}) |
AlbertMarashi
force-pushed
the
async-function-for-template
branch
from
8268430
to
638fd27
Compare
|
Tests for But code works fine |
AlbertMarashi
changed the title
|
@yyx990803 will this be making 2.6? If so, I can assist in writing the documentation for this feature |
lbogdan
reviewed
Jan 19, 2019
| @@ -23,7 +23,7 @@ export type RenderOptions = { | |||
| directives?: Object; | |||
| isUnaryTag?: Function; | |||
| cache?: RenderCache; | |||
| template?: string; | |||
| template?: string | (content: string, context: any) => string; | |||
There was a problem hiding this comment.
Wouldn't (context, content) be a better API, consistent with, for example, vuex actions, which have context as their first argument?
f2009
pushed a commit
to f2009/vue
that referenced
this pull request
Jan 25, 2019
…ejs#9324) Also allows return Promise for async handling
f2009
pushed a commit
to f2009/vue
that referenced
this pull request
Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
@yyx990803 I've found a solution to #9205
It's a very simple addition, to the
vue-server-rendererpackage that has tonnes of use-cases and actually makes thevue-server-renderermuch easier to use, as it provides a template function to the bundle renderer template compiler.This isn't a breaking change and doesn't really need any tests, as it is a user-provided function
It would be amazing if this could be added in 2.6, so I could use it in my package
Use cases
single file components(see [ssr] Add Vue function to render VNode to html string #9205)templateoptionvue-server-renderertemplater much easier to use, and allows users to use javascript interpolations. For example:<!--vue-ssr-outlet-->becomes${result}Bonus
I'm creating a serverside rendering templating engine for Vue that will use this feature. It includes:
<template>, like native htmlThe package is aimed for users who want to start using Vue but want to keep express/koa routing which will make building serverside applications much easier for users, and will increase Vue adoption in the process