fix #6931: Clean up target variables to avoid memory leaks #6932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenduru
force-pushed
the
fix-listeners-memory-leak
branch
from
d533cfe
to
d7e14f6
Compare
fenduru
commented
Oct 26, 2017
| @@ -19,7 +19,7 @@ export function initEvents (vm: Component) { | |||
| } | |||
| } | |||
|
|
|||
| let target: Component | |||
| let target: any | |||
There was a problem hiding this comment.
I don't love removing the type annotation here, but if I left it as Component then Flow would see the assignment to undefined and error due to "Possible undefined value".
In typescript you can tell the type checker to trust you by doing target!.method() but I couldn't find an equivilent in Flow. The Flow docs recommend if (target !== undefined), however I didn't think we'd want to add a branch in the VDom code.
There was a problem hiding this comment.
What about just binding the add and remove methods to the vm so you don't need this closure variable at all?
There was a problem hiding this comment.
@chriscasola You won't wanna do it that way. function.bind is just create a closure.
erweixin
pushed a commit
to erweixin/vue
that referenced
this pull request
Dec 15, 2017
lovelope
pushed a commit
to lovelope/vue
that referenced
this pull request
Feb 1, 2018
This was referenced Mar 14, 2018
f2009
pushed a commit
to f2009/vue
that referenced
this pull request
Jan 25, 2019
aJean
pushed a commit
to aJean/vue
that referenced
this pull request
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
The development environment on Windows is flaky and crashes a lot. I'm also seeing intermittent failures that seem unrelated to my change (they also occur on the
devbranch with no changes). Filing the PR now to get feedback and to see if CI has the same failures.