Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow an extended constructor as global mixin (fix vue-class-component#83) #5448

Merged
merged 1 commit into from Apr 16, 2017

Conversation

ktsn
Copy link
Member

@ktsn ktsn commented Apr 15, 2017

What kind of change does this PR introduce? (check at least one)

  • Bugfix (might be a new feature)
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

Other information:
This PR moves a constructor check in mergeOptions to the head of the function so that we can use a extended Vue constructor not only as mixins/extends options but also as global mixin. This fixes vuejs/vue-class-component#83

@yyx990803 yyx990803 merged commit 086ae44 into vuejs:dev Apr 16, 2017
@ktsn ktsn deleted the global-mixin-for-constructor branch April 16, 2017 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define mixin global does not work
4 participants