Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix no change triggered after reassigned state, Fix #5191 #5233

Merged
merged 1 commit into from Mar 21, 2017

Conversation

Kingwl
Copy link
Member

@Kingwl Kingwl commented Mar 20, 2017

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
#5191

Copy link
Member

@znck znck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@posva
Copy link
Member

posva commented Mar 20, 2017

hey @Kingwl don't forget the Fix #5191 in the git commit message 🙂

@Kingwl
Copy link
Member Author

Kingwl commented Mar 20, 2017

@posva done🌚

@defcc
Copy link
Member

defcc commented Mar 20, 2017

@Kingwl You could update the PR title, the issue number should be referenced in the PR title for a better release log :)

When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

@Kingwl Kingwl changed the title fix no change triggered after reassigned state fix no change triggered after reassigned state, Fix #5191 Mar 21, 2017
@yyx990803 yyx990803 merged commit 4c4a2ab into vuejs:dev Mar 21, 2017
@Kingwl Kingwl deleted the dev-update-hook branch March 21, 2017 09:13
awamwang pushed a commit to awamwang/vue that referenced this pull request Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants