Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SSR v-show render. #5224

Merged
merged 4 commits into from Mar 21, 2017
Merged

fix SSR v-show render. #5224

merged 4 commits into from Mar 21, 2017

Conversation

defcc
Copy link
Member

@defcc defcc commented Mar 19, 2017

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

SSR v-show directive should be merged from parent to child component.

It could be reproduced via this github repo.

And the demo code is bellow:

var Vue = require('vue/dist/vue.common.js')
var createRenderer = require('vue-server-renderer').createRenderer
var renderToString = createRenderer().renderToString

const vm = new Vue({
  template: `
    <foo v-show="false"></foo>
  `,
  components: {
    foo: {
      render: h => h('bar'),
      components: {
        bar: {
          render: h => h('div', 'inner')
        }
      }
    }

  }
})

renderToString(vm, (err, res) => {
  console.log(res)
})

The result is <div server-rendered="true">inner</div>, it should be <div server-rendered="true" style="display:none;">inner</div>

@yyx990803 yyx990803 merged commit e733e5c into vuejs:dev Mar 21, 2017
awamwang pushed a commit to awamwang/vue that referenced this pull request Jun 15, 2017
* fix SSR v-show bug. v-show info needs to be merged from parent to child component

* improve variable name

* update test case

* update test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants