Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add pnpm v4 support #4677

Merged
merged 16 commits into from Oct 16, 2019
Merged

fix: add pnpm v4 support #4677

merged 16 commits into from Oct 16, 2019

Conversation

B4rtware
Copy link
Contributor

in pnpm v4 the option '--loglevel' is no longer available instead '--reporter' is used.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:
--reporter silent should replicate --loglevel error
and --shamefully-flatten was renamed to --shamefully-hoist

in pnpm v4 the option '--loglevel' is no longer available instead '--reporter' is used.
Copy link
Contributor

@pksunkara pksunkara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's better if you read pnpm version and set all the flags at once instead of so much duplicated code

packages/@vue/cli-shared-utils/lib/env.js Outdated Show resolved Hide resolved
Co-Authored-By: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
@B4rtware
Copy link
Contributor Author

Maybe it's better if you read pnpm version and set all the flags at once instead of so much duplicated code

You are right! I will try to find a solution.

packages/@vue/cli-shared-utils/lib/env.js Outdated Show resolved Hide resolved
packages/@vue/cli-shared-utils/lib/env.js Outdated Show resolved Hide resolved
packages/@vue/cli-shared-utils/lib/env.js Outdated Show resolved Hide resolved
packages/@vue/cli-shared-utils/lib/env.js Outdated Show resolved Hide resolved
@sodatea sodatea merged commit badf63d into vuejs:dev Oct 16, 2019
@vue-bot
Copy link

vue-bot commented Oct 16, 2019

Hey @B4rtware, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants