feat: support PNPM as a package manager #1531
Conversation
|
@Akryum I think this PR is ready. Could you check it, please? |
|
Appveyor tests are working now, you should probably rebase on master so that the PR status is green |
packages/@vue/cli/lib/Creator.js
Outdated
| }) | ||
| } | ||
|
|
||
| packageManagerChoices.push({ |
There was a problem hiding this comment.
What do you think to move npm choice at the end of choices?
It will increase code readability and also keep some consistency with this pattern:
if (hasYarn()) {
// Do Yarn thing
}
if (hasPnpm()) {
// Do PNPM thing
}
// Do NPM thing
|
@robertkruis Can you address the review comment and rebase the PR please? Thanks. |
|
Is this initiative dead? |
|
@owalerys: the initiative certainly isn't dead. Due to some other obligations I did not have the time to update this PR and make the necessary changes. I'll be having more free time soon and get back to it. |
robertkruis
force-pushed
the
pnpm-support
branch
from
0b33a66
to
9c1e797
Compare
|
@pksunkara Seems to be everything great now and ready for merging. |
|
Could you add a check for installed pnpm version? I think we are only compatible with pnpm v3. |
as a follow up of #1531 1. separate project pnpm check and global pnpm check 2. rename `hasPnpm` to `hasPnpm3OrLater` 3. add `--shamefully-flatten` flag for `pnpm install` 4. generate `.npmrc` when using pnpm as package manager, to persist the install flag
Enables vue-cli to use PNPM (https://pnpm.js.org/) as package manager