perf(task details): better defering

vuejs · Apr 10, 2019 · ecd64c4 · ecd64c4
1 parent 4f0286c
commit ecd64c4
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 7 deletions.
diff --git a/packages/@vue/cli-ui/src/components/task/ProjectTaskDetails.vue b/packages/@vue/cli-ui/src/components/task/ProjectTaskDetails.vue
@@ -77,7 +77,11 @@
         </VueGroup>
       </div>
 
-      <div v-if="displayPriority >= 2" class="content">
+      <div v-if="!defer(3)" class="content placeholder-content">
+        <div class="view card"/>
+      </div>
+
+      <div v-else class="content">
         <TerminalView
           ref="terminal"
           :class="{
@@ -133,7 +137,7 @@
 
 <script>
 import Prompts from '@/mixins/Prompts'
-import DisplayPriority from '@/mixins/DisplayPriority'
+import Defer from '@/mixins/Defer'
 
 import TASK from '@/graphql/task/task.gql'
 import TASK_LOGS from '@/graphql/task/taskLogs.gql'
@@ -159,7 +163,7 @@ export default {
       field: 'task',
       query: TASK
     }),
-    DisplayPriority(2)
+    Defer()
   ],
 
   metaInfo () {
@@ -199,7 +203,7 @@ export default {
         }
       },
       skip () {
-        return this.displayPriority < 1
+        return !this.defer(2)
       }
     },
 
@@ -222,7 +226,7 @@ export default {
         }
       },
       skip () {
-        return this.displayPriority < 2
+        return !this.defer(3)
       }
     },
 
@@ -242,7 +246,7 @@ export default {
           }
         },
         skip () {
-          return this.displayPriority < 2
+          return !this.defer(3)
         }
       }
     }
@@ -259,6 +263,7 @@ export default {
           return id
         }
       }
+      return null
     }
   },
 
@@ -370,6 +375,7 @@ export default {
   margin 0 $padding-item $padding-item
   position relative
 
+.placeholder-content .view,
 .terminal-view
   position absolute
   top 0

diff --git a/...@vue/cli-ui/src/mixins/DisplayPriority.js → packages/@vue/cli-ui/src/mixins/Defer.js b/...@vue/cli-ui/src/mixins/DisplayPriority.js → packages/@vue/cli-ui/src/mixins/Defer.js
@@ -1,4 +1,4 @@
-export default function (count = 1) {
+export default function (count = 10) {
   // @vue/component
   return {
     data () {
@@ -13,6 +13,7 @@ export default function (count = 1) {
 
     methods: {
       runDisplayPriority () {
+        this.displayPriority = 0
         const step = () => {
           requestAnimationFrame(() => {
             this.displayPriority++
@@ -22,6 +23,10 @@ export default function (count = 1) {
           })
         }
         step()
+      },
+
+      defer (priority) {
+        return this.displayPriority >= priority
       }
     }
   }