Update: validate void operator in no-constant-condition (Fixes eslint…

…#5726)
vitorbal · Apr 1, 2016 · 9c8f211 · 9c8f211
1 parent e54598a
commit 9c8f211
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/docs/rules/no-constant-condition.md b/docs/rules/no-constant-condition.md
@@ -26,6 +26,10 @@ if (false) {
     doSomethingUnfinished();
 }
 
+if (void x) {
+    doSomethingUnfinished();
+}
+
 for (;true;) {
     doSomethingForever();
 }
@@ -34,7 +38,7 @@ while (-2) {
     doSomethingForever();
 }
 
-do{
+do {
     doSomethingForever();
 } while (x = -1);
 

diff --git a/lib/rules/no-constant-condition.js b/lib/rules/no-constant-condition.js
@@ -32,6 +32,9 @@ module.exports = function(context) {
                 return true;
 
             case "UnaryExpression":
+                if (node.operator === "void") {
+                    return true;
+                }
                 return isConstant(node.argument);
 
             case "BinaryExpression":

diff --git a/tests/lib/rules/no-constant-condition.js b/tests/lib/rules/no-constant-condition.js
@@ -26,6 +26,7 @@ ruleTester.run("no-constant-condition", rule, {
         "if(a = f());",
         "if(1, a);",
         "if ('every' in []);",
+        "if (a || void a);",
         "while(~!a);",
         "while(a = b);",
         "for(;x < 10;);",
@@ -47,6 +48,11 @@ ruleTester.run("no-constant-condition", rule, {
         { code: "if(0 < 1);", errors: [{ message: "Unexpected constant condition.", type: "IfStatement"}] },
         { code: "if(0 || 1);", errors: [{ message: "Unexpected constant condition.", type: "IfStatement"}] },
         { code: "if(a, 1);", errors: [{ message: "Unexpected constant condition.", type: "IfStatement"}] },
+        { code: "if(1 || void x);", errors: [{ message: "Unexpected constant condition.", type: "IfStatement"}] },
+        { code: "if(void x);", errors: [{ message: "Unexpected constant condition.", type: "IfStatement"}] },
+        { code: "if(y = void x);", errors: [{ message: "Unexpected constant condition.", type: "IfStatement"}] },
+        { code: "if(x, void x);", errors: [{ message: "Unexpected constant condition.", type: "IfStatement"}] },
+        { code: "if(void x === void y);", errors: [{ message: "Unexpected constant condition.", type: "IfStatement"}] },
         { code: "while([]);", errors: [{ message: "Unexpected constant condition.", type: "WhileStatement"}] },
         { code: "while(~!0);", errors: [{ message: "Unexpected constant condition.", type: "WhileStatement"}] },
         { code: "while(x = 1);", errors: [{ message: "Unexpected constant condition.", type: "WhileStatement"}] },