[build-utils] Fix warn for ignored project settings node version #11550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c9ce439 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
onsclom
force-pushed
the
austinmerrick/zero-1725-print-warning-message-about-changed-node-version-due-to
branch
from
2abbb69
to
58b832b
Compare
onsclom
requested review from
TooTallNate,
EndangeredMassa,
trek,
jeffsee55 and
erikareads
as code owners
TooTallNate
reviewed
May 7, 2024
onsclom
force-pushed
the
austinmerrick/zero-1725-print-warning-message-about-changed-node-version-due-to
branch
from
ad0130e
to
119e2e5
Compare
…e-about-changed-node-version-due-to
…e-about-changed-node-version-due-to
TooTallNate
reviewed
May 8, 2024
Co-authored-by: Nathan Rajlich <n@n8.io>
…e-about-changed-node-version-due-to
…e-about-changed-node-version-due-to
…e-about-changed-node-version-due-to
…e-about-changed-node-version-due-to
erikareads
approved these changes
May 14, 2024
…e-about-changed-node-version-due-to
kodiakhq
bot
deleted the
austinmerrick/zero-1725-print-warning-message-about-changed-node-version-due-to
branch
Merged
EndangeredMassa
pushed a commit
that referenced
this pull request
May 15, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @vercel/build-utils@8.2.0 ### Minor Changes - fix corepack detection for package manager version determination ([#11596](#11596)) ### Patch Changes - Fix triggering of ignored project settings node version warning ([#11550](#11550)) ## vercel@34.2.0 ### Minor Changes - Stop sending system environment variables in dev ([#11526](#11526)) ### Patch Changes - Updated dependencies \[[`d3c1267e2`](d3c1267), [`ccd7eb1fb`](ccd7eb1)]: - @vercel/build-utils@8.2.0 - @vercel/node@3.1.5 - @vercel/static-build@2.5.9 ## @vercel/client@13.2.7 ### Patch Changes - Updated dependencies \[[`d3c1267e2`](d3c1267), [`ccd7eb1fb`](ccd7eb1)]: - @vercel/build-utils@8.2.0 ## @vercel/gatsby-plugin-vercel-builder@2.0.31 ### Patch Changes - Updated dependencies \[[`d3c1267e2`](d3c1267), [`ccd7eb1fb`](ccd7eb1)]: - @vercel/build-utils@8.2.0 ## @vercel/node@3.1.5 ### Patch Changes - Updated dependencies \[[`d3c1267e2`](d3c1267), [`ccd7eb1fb`](ccd7eb1)]: - @vercel/build-utils@8.2.0 ## @vercel/static-build@2.5.9 ### Patch Changes - Updated dependencies \[]: - @vercel/gatsby-plugin-vercel-builder@2.0.31 ## @vercel-internals/types@1.0.36 ### Patch Changes - Updated dependencies \[[`d3c1267e2`](d3c1267), [`ccd7eb1fb`](ccd7eb1)]: - @vercel/build-utils@8.2.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were scenarios where the warning "Node.js Version defined in your Project Settings ("18.x") will not apply" would not be triggered. For example:
This fixes that scenario by getting the supported node version first.