[next] Only rewrite next-action requests to .action handlers
#11504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 863deb5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ztanner
requested review from
TooTallNate,
EndangeredMassa,
trek,
onsclom,
jeffsee55,
erikareads,
timneutkens,
ijjk,
huozhi,
Ethan-Arrowood and
styfle
as code owners
ijjk
previously approved these changes
Apr 27, 2024
Stacked on #11504 This adds the rewrite handling behind an additional env var gate. I've added tests validating the behavior with/without the flag enabled.
ijjk
previously approved these changes
Apr 29, 2024
TooTallNate
reviewed
Apr 30, 2024
TooTallNate
reviewed
Apr 30, 2024
ijjk
approved these changes
Apr 30, 2024
Merged
TooTallNate
pushed a commit
that referenced
this pull request
Apr 30, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## vercel@34.1.6 ### Patch Changes - Updated dependencies \[[`b1adaf76e`](b1adaf7), [`3fb97d1d2`](3fb97d1)]: - @vercel/next@4.2.5 - @vercel/static-build@2.5.2 ## @vercel/next@4.2.5 ### Patch Changes - Only rewrite next-action requests to `.action` handlers ([#11504](#11504)) ## @vercel/static-build@2.5.2 ### Patch Changes - Revert `SUPPORTED_RUBY_VERSION` change to fix Ruby site generators on AL2 build image ([#11522](#11522)) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only rewrites requests that contain a
next-actionheader (explicitly indicating it's a server action). A side effect is that POST requests to a server action on a static route, without a next-action header, won't be marked as streaming (but will still execute normally). This is fine as only the handled action needs to stream.This relands .action handling behind a feature flag.