Fix missing .rsc outputs for pages prerenders #11503
Merged
+94
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c636108 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ijjk
requested review from
TooTallNate,
EndangeredMassa,
trek,
onsclom,
jeffsee55,
erikareads,
timneutkens,
ztanner,
huozhi,
Ethan-Arrowood and
styfle
as code owners
TooTallNate
approved these changes
Apr 30, 2024
ztanner
approved these changes
Apr 30, 2024
ijjk
added a commit
that referenced
this pull request
Apr 30, 2024
Noticed in #11503 that this test fixture is incorrectly locked to a specific version when we don't want it to be.
Merged
TooTallNate
pushed a commit
that referenced
this pull request
May 3, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## vercel@34.1.8 ### Patch Changes - Updated dependencies \[[`52e435aa5`](52e435a), [`124846a3e`](124846a), [`dc974b679`](dc974b6), [`58c6755e0`](58c6755)]: - @vercel/next@4.2.7 - @vercel/static-build@2.5.3 ## @vercel/next@4.2.7 ### Patch Changes - Fix missing .rsc outputs for pages prerenders ([#11503](#11503)) - Fix base path app index RSC handling ([#11528](#11528)) - Fix interception routes PPR route handling ([#11527](#11527)) ## @vercel/static-build@2.5.3 ### Patch Changes - Support Ruby and Python static site generators in AL2023 build image ([#11529](#11529)) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating the outputs for pages when app router is also present we weren't creating the placeholder
.rscoutputs for all prerender outputs so when afallback: falseroute was configured in the pages router that could fall through to an app route it causes issues with client-navigation behaving differently than a direct visit.This ensures we add the placeholder
.rscoutputs for all prerenders so thatfallback: falsepages don't have this unexpected behavior.