Update pnpm version detection logic #11445
Merged
+394
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 89e22e2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
erikareads
force-pushed
the
erikarowland/zero-1812-detect-pnpm-lockfile-version-to-determine-pnpm-version
branch
from
618ddff
to
1ccdded
Compare
erikareads
requested review from
TooTallNate,
EndangeredMassa,
trek,
onsclom and
jeffsee55
as code owners
TooTallNate
reviewed
Apr 17, 2024
…version-to-determine-pnpm-version
…version-to-determine-pnpm-version
…version-to-determine-pnpm-version
EndangeredMassa
approved these changes
Apr 26, 2024
Comment on lines
+772
to
+784
| switch (true) { | ||
| case cliType === 'yarn' && !env.YARN_NODE_LINKER: | ||
| return { ...overrides, yarnNodeLinker: 'node-modules' }; | ||
| case alreadyInPath(overrides.path ?? ''): | ||
| return { | ||
| detectedLockfile: undefined, | ||
| detectedPackageManager: undefined, | ||
| path: undefined, | ||
| yarnNodeLinker: undefined, | ||
| }; | ||
| default: | ||
| return { ...overrides, yarnNodeLinker: undefined }; | ||
| } |
There was a problem hiding this comment.
suggestion (non-blocking): ifs over switches?
The switch-true pattern is harder to understand than the equivalent if-return or if-else, in my opinion. I suggest changing this, but it's up to you.
…version-to-determine-pnpm-version
…version-to-determine-pnpm-version
EndangeredMassa
added
the
pr: automerge
ztanner
added
pr: automerge
…version-to-determine-pnpm-version
EndangeredMassa
removed
the
pr: automerge
…version-to-determine-pnpm-version
EndangeredMassa
added
the
pr: automerge
…version-to-determine-pnpm-version
kodiakhq
bot
deleted the
erikarowland/zero-1812-detect-pnpm-lockfile-version-to-determine-pnpm-version
branch
Merged
EndangeredMassa
pushed a commit
that referenced
this pull request
May 11, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @vercel/build-utils@8.1.0 ### Minor Changes - Update pnpm version detection logic ([#11445](#11445)) Add support for pnpm 9 ## vercel@34.1.11 ### Patch Changes - Updated dependencies \[[`5014b1e82`](5014b1e), [`18d1703d5`](18d1703), [`e87d4c14d`](e87d4c1), [`bc5fd4115`](bc5fd41)]: - @vercel/build-utils@8.1.0 - @vercel/next@4.2.10 - @vercel/redwood@2.0.9 - @vercel/remix-builder@2.1.6 - @vercel/node@3.1.1 - @vercel/static-build@2.5.5 ## @vercel/client@13.2.3 ### Patch Changes - Updated dependencies \[[`5014b1e82`](5014b1e)]: - @vercel/build-utils@8.1.0 ## @vercel/gatsby-plugin-vercel-builder@2.0.27 ### Patch Changes - Updated dependencies \[[`5014b1e82`](5014b1e)]: - @vercel/build-utils@8.1.0 ## @vercel/next@4.2.10 ### Patch Changes - skip action rewrites for RSC requests ([#11576](#11576)) - Bump `@vercel/nft@0.27.0` ([#11580](#11580)) ## @vercel/node@3.1.1 ### Patch Changes - Bump `@vercel/nft@0.27.0` ([#11580](#11580)) - Updated dependencies \[[`5014b1e82`](5014b1e)]: - @vercel/build-utils@8.1.0 ## @vercel/redwood@2.0.9 ### Patch Changes - Bump `@vercel/nft@0.27.0` ([#11580](#11580)) ## @vercel/remix-builder@2.1.6 ### Patch Changes - Bump `@vercel/nft@0.27.0` ([#11580](#11580)) - Update `@remix-run/dev` fork to v2.9.2-patch.2 ([#11582](#11582)) ## @vercel/static-build@2.5.5 ### Patch Changes - Updated dependencies \[]: - @vercel/gatsby-plugin-vercel-builder@2.0.27 ## @vercel-internals/types@1.0.32 ### Patch Changes - Updated dependencies \[[`5014b1e82`](5014b1e)]: - @vercel/build-utils@8.1.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code we use to detect the version of
pnpmbased on lockfiles is hard to follow. It doesn't pick and executable, it instead of sometimes overrides thePATHfor these utilities with a prepended alternate path.This means that there is no one single place where we definitively specify which version of
pnpmthat is used, so much as hope that thePATHhas the correct version on it. I don't know that we can specify an executable outside of the build container, and it's unclear, since this is a package, whether this utility is used outside of a build container setting.In this pull request I cleaned up the code and updated the logic to include the
pnpm 7andpnpm 8changes requested, with no changes yet to implementpnpm 9.It's possible that we want to rewrite this detection logic from scratch to avoid this roundabout way of "finding" the executable, but I haven't done that here.