Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore mock client TS errors #11345

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Conversation

jeffsee55
Copy link
Contributor

@jeffsee55 jeffsee55 commented Mar 29, 2024

I think the appropriate fix is probably more nuanced than simply reverting changes here, but this does fix the ts errors in our unit tests See below

Context: #10090 (review)

Copy link

changeset-bot bot commented Mar 29, 2024

🦋 Changeset detected

Latest commit: a98b4fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@vercel-internals/types Patch
vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jeffsee55
Copy link
Contributor Author

jeffsee55 commented Mar 29, 2024

Yeah that first effort wasn't gonna work. I think the basically the issue is the mock client uses streams to mock tty stdio and those types are never going to overlap properly.

I tried for a bit to use stubbed tty.WriteStream/tty.ReadStream but couldn't get everything working.

This PR pretty much just ignores the type errors in the mock client so we don't see a bunch of errors in the tests.

@jeffsee55 jeffsee55 changed the title Revert type updates to fix broken typescript in tests Ignore mock client TS errors Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant