New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore mock client TS errors #11345
base: main
Are you sure you want to change the base?
Ignore mock client TS errors #11345
Conversation
🦋 Changeset detectedLatest commit: a98b4fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Yeah that first effort wasn't gonna work. I think the basically the issue is the mock client uses streams to mock tty stdio and those types are never going to overlap properly. I tried for a bit to use stubbed This PR pretty much just ignores the type errors in the mock client so we don't see a bunch of errors in the tests. |
I think the appropriate fix is probably more nuanced than simply reverting changes here, but this does fix the ts errors in our unit testsSee belowContext: #10090 (review)