Fix: secure attribute cannot be set when deleting a cookie #65649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonoakij
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
feedthejim,
ztanner and
wyattjoh
as code owners
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
nonoakij
changed the title
nonoakij
changed the title
nonoakij
changed the title
ijjk
requested changes
May 13, 2024
There was a problem hiding this comment.
Looks like this needs to be updated upstream as this is just the vendored version of https://github.com/vercel/edge-runtime/tree/main/packages/cookies
|
@ijjk |
|
@ijjk I have created a pull request, could you please check it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #56632
To delete a cookie with the prefix
__Secure-, it must besecure.Previously, the value of secure was not set correctly.
(In typescript, d.ts is
options: Omit<ResponseCookie, 'value' | 'expires'>, so it is not an error but not actually set).This PR solves this problem.
reproduce repository
https://github.com/nonoakij/reproduce-cookie-delete