Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update middleware example to App Router #65618

Merged
merged 5 commits into from May 13, 2024

Conversation

dnhn
Copy link
Contributor

@dnhn dnhn commented May 10, 2024

What?

Update the middleware example to Next.js 14 App Router.

Why?

App Router is recommended.

How?

Follow Next.js App Router documentation.

@dnhn dnhn requested review from a team as code owners May 10, 2024 16:11
@dnhn dnhn requested review from manovotny and delbaoliveira and removed request for a team May 10, 2024 16:11
@ijjk ijjk added the examples Issue/PR related to examples label May 10, 2024
@ijjk
Copy link
Member

ijjk commented May 10, 2024

Allow CI Workflow Run

  • approve CI run for commit: e3b0831

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a PR! Looks good to me.

@samcx samcx enabled auto-merge (squash) May 13, 2024 20:44
@samcx samcx merged commit 359fdb2 into vercel:canary May 13, 2024
33 checks passed
panteliselef pushed a commit to panteliselef/next.js that referenced this pull request May 20, 2024
### What?
Update the `middleware` example to Next.js 14 App Router.

### Why?
App Router is recommended.

### How?
Follow Next.js App Router documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants