Remove component init hook

Remove component `ready` hook
uikit · Sep 25, 2018 · 612c26e · 612c26e
1 parent 297cf54
commit 612c26e
Show file tree

Hide file tree

Showing 11 changed files with 9 additions and 30 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -16,6 +16,8 @@
 ### Removed
 
 - Remove `::-moz-selection` which is not needed anymore
+- Remove component `init` hook
+- Remove component `ready` hook
 
 ### Fixed
 

diff --git a/src/js/api/global.js b/src/js/api/global.js
@@ -70,7 +70,7 @@ export default function (UIkit) {
         }
 
         for (const name in data) {
-            if (data[name]._isReady) {
+            if (data[name]._connected) {
                 data[name]._callUpdate(e);
             }
         }

diff --git a/src/js/api/hooks.js b/src/js/api/hooks.js
@@ -27,11 +27,6 @@ export default function (UIkit) {
         this._initObserver();
 
         this._callHook('connected');
-
-        if (!this._isReady) {
-            ready(() => this._callReady());
-        }
-
         this._callUpdate();
     };
 
@@ -55,18 +50,6 @@ export default function (UIkit) {
 
     };
 
-    UIkit.prototype._callReady = function () {
-
-        if (this._isReady) {
-            return;
-        }
-
-        this._isReady = true;
-        this._callHook('ready');
-        this._resetComputeds();
-        this._callUpdate();
-    };
-
     UIkit.prototype._callUpdate = function (e) {
 
         e = createEvent(e || 'update');

diff --git a/src/js/api/instance.js b/src/js/api/instance.js
@@ -20,8 +20,6 @@ export default function (UIkit) {
 
         this.$el = this.$options.el = this.$options.el || el;
 
-        this._callHook('init');
-
         if (within(el, document)) {
             this._callConnected();
         }

diff --git a/src/js/components/notification.js b/src/js/components/notification.js
@@ -37,7 +37,7 @@ export default {
 
     },
 
-    ready() {
+    connected() {
 
         const marginBottom = toFloat(css(this.$el, 'marginBottom'));
         Transition.start(

diff --git a/src/js/components/sortable.js b/src/js/components/sortable.js
@@ -34,7 +34,7 @@ export default {
         handle: false
     },
 
-    init() {
+    created() {
         ['init', 'start', 'move', 'end'].forEach(key => {
             const fn = this[key];
             this[key] = e => {

diff --git a/src/js/core/core.js b/src/js/core/core.js
@@ -4,6 +4,8 @@ export default function (UIkit) {
 
     ready(() => {
 
+        UIkit.update();
+
         let scroll = 0;
         let started = 0;
 

diff --git a/src/js/core/drop.js b/src/js/core/drop.js
@@ -49,7 +49,7 @@ export default {
 
     },
 
-    init() {
+    created() {
         this.tracker = new MouseTracker();
     },
 

diff --git a/src/js/core/video.js b/src/js/core/video.js
@@ -28,10 +28,6 @@ export default {
             this.$el.preload = 'none';
         }
 
-    },
-
-    ready() {
-
         this.player = new Player(this.$el);
 
         if (this.automute) {

diff --git a/src/js/mixin/slider-drag.js b/src/js/mixin/slider-drag.js
@@ -7,7 +7,7 @@ export default {
         preventCatch: false
     },
 
-    init() {
+    created() {
 
         ['start', 'move', 'end'].forEach(key => {
 

diff --git a/src/js/util/options.js b/src/js/util/options.js
@@ -5,11 +5,9 @@ const strats = {};
 // concat strategy
 strats.args =
 strats.events =
-strats.init =
 strats.created =
 strats.beforeConnect =
 strats.connected =
-strats.ready =
 strats.beforeDisconnect =
 strats.disconnected =
 strats.destroy = function (parentVal, childVal) {