New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(typescript-estree): stabilize EXPERIMENTAL_useProjectService as projectService #9084
base: v8
Are you sure you want to change the base?
feat(typescript-estree): stabilize EXPERIMENTAL_useProjectService as projectService #9084
Conversation
…e as projectService
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
projectService
looks much better than EXPERIMENTAL_useProjectService
😎
Co-authored-by: auvred <61150013+auvred@users.noreply.github.com>
PR Checklist
Overview
Updates the naming and JSDoc-style comments around:
EXPERIMENTAL_useProjectService
: simplifying it to justprojectService
allowDefaultProjectForFiles
: simplifying it toallowDefaultProject
TYPESCRIPT_ESLINT_EXPERIMENTAL_TSSERVER
: updates it toTYPESCRIPT_ESLINT_PROJECT_SERVICE
This is in parallel to #8031, which will need to be updated after this.
Also filed a separate #9085 to update the rest of our docs. I think that'll end up needing more discussion, so I'd like to get this in sooner & first.
💖