Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript-estree): stabilize EXPERIMENTAL_useProjectService as projectService #9084

Open
wants to merge 5 commits into
base: v8
Choose a base branch
from

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented May 13, 2024

PR Checklist

Overview

Updates the naming and JSDoc-style comments around:

  • EXPERIMENTAL_useProjectService: simplifying it to just projectService
  • allowDefaultProjectForFiles: simplifying it to allowDefaultProject
  • TYPESCRIPT_ESLINT_EXPERIMENTAL_TSSERVER: updates it to TYPESCRIPT_ESLINT_PROJECT_SERVICE

This is in parallel to #8031, which will need to be updated after this.

Also filed a separate #9085 to update the rest of our docs. I think that'll end up needing more discussion, so I'd like to get this in sooner & first.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@JoshuaKGoldberg JoshuaKGoldberg modified the milestones: v8, 8.0.0 May 13, 2024
Copy link

netlify bot commented May 13, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit abae6c2
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66422b7e794a460008a68aaf
😎 Deploy Preview https://deploy-preview-9084--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented May 13, 2024

@JoshuaKGoldberg JoshuaKGoldberg requested review from bradzacher and a team May 13, 2024 00:46
Copy link
Member

@auvred auvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

projectService looks much better than EXPERIMENTAL_useProjectService 😎

docs/packages/Parser.mdx Outdated Show resolved Hide resolved
packages/typescript-estree/src/parseSettings/index.ts Outdated Show resolved Hide resolved
@auvred auvred added the awaiting response Issues waiting for a reply from the OP or another party label May 13, 2024
JoshuaKGoldberg and others added 3 commits May 13, 2024 08:00
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review May 13, 2024 15:02
@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants