-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): add brace-style [extension] #810
feat(eslint-plugin): add brace-style [extension] #810
Conversation
Thanks for the PR, @a-tarasyuk! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint |
…ipt-eslint into feature/brace-style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code so far LGTM.
Good work figuring out all of the things to create an extension rule.
I think we probably want to also add support for the other typescript features that can be considered "blocks" whilst we're here.
enum
s
enum Foo {
a = 1,
}
namespace
/ module
s
namespace Foo {
}
module Bar {
}
@bradzacher ok. Does |
It does not - so it'll be just little bit more work to implement. module/namespace has a body so it should be simple as to add. |
…ipt-eslint into feature/brace-style
…ypescript-eslint into feature/brace-style
Codecov Report
@@ Coverage Diff @@
## master #810 +/- ##
==========================================
+ Coverage 94.06% 94.07% +0.01%
==========================================
Files 113 114 +1
Lines 4937 4946 +9
Branches 1378 1378
==========================================
+ Hits 4644 4653 +9
Misses 166 166
Partials 127 127
|
Added.
Oke |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for this
…ipt-eslint into feature/brace-style
…ypescript-eslint into feature/brace-style
Fixes #804