Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): add brace-style [extension] #810

Merged
merged 20 commits into from Sep 6, 2019

Conversation

a-tarasyuk
Copy link
Contributor

@a-tarasyuk a-tarasyuk commented Aug 6, 2019

Fixes #804

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @a-tarasyuk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint

@bradzacher bradzacher added the enhancement: new base rule extension New base rule extension required to handle a TS specific case label Aug 6, 2019
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code so far LGTM.
Good work figuring out all of the things to create an extension rule.

I think we probably want to also add support for the other typescript features that can be considered "blocks" whilst we're here.

enums

enum Foo {
  a = 1,
}

namespace / modules

namespace Foo {

}

module Bar {

}

@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Aug 19, 2019
@a-tarasyuk
Copy link
Contributor Author

@bradzacher ok. Does enum have the property body?

@bradzacher
Copy link
Member

It does not - so it'll be just little bit more work to implement.
I'm more than happy to punt on that one for now until someone asks for it!

module/namespace has a body so it should be simple as to add.

@codecov
Copy link

codecov bot commented Aug 20, 2019

Codecov Report

Merging #810 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #810      +/-   ##
==========================================
+ Coverage   94.06%   94.07%   +0.01%     
==========================================
  Files         113      114       +1     
  Lines        4937     4946       +9     
  Branches     1378     1378              
==========================================
+ Hits         4644     4653       +9     
  Misses        166      166              
  Partials      127      127
Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/brace-style.ts 100% <100%> (ø)
packages/eslint-plugin/src/rules/index.ts 100% <100%> (ø) ⬆️

@a-tarasyuk
Copy link
Contributor Author

@bradzacher

module/namespace has a body so it should be simple as to add.

Added.

I'm more than happy to punt on that one for now until someone asks for it!

Oke

bradzacher
bradzacher previously approved these changes Aug 20, 2019
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this

@bradzacher bradzacher added 1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready and removed awaiting response Issues waiting for a reply from the OP or another party labels Aug 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready enhancement: new base rule extension New base rule extension required to handle a TS specific case
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[brace-style] 1tbs not enforced with interfaces
2 participants