New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin): [unified-signatures] crash: cannot read property 'name' of null #1096
fix(eslint-plugin): [unified-signatures] crash: cannot read property 'name' of null #1096
Conversation
Thanks for the PR, @a-tarasyuk! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
…read-property-name-of-null
…ipt-eslint into bug/1078-unified-signatures-crash--cannot-read-property-name-of-null
…-name-of-null' of https://github.com/a-tarasyuk/typescript-eslint into bug/1078-unified-signatures-crash--cannot-read-property-name-of-null
…read-property-name-of-null
Codecov Report
@@ Coverage Diff @@
## master #1096 +/- ##
==========================================
- Coverage 94.15% 94.13% -0.02%
==========================================
Files 124 124
Lines 5336 5337 +1
Branches 1492 1493 +1
==========================================
Hits 5024 5024
Misses 178 178
- Partials 134 135 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please correct the type of TSDeclareFunction.id
as part of this PR?
id: Identifier; |
@bradzacher Sure |
…ipt-eslint into bug/1078-unified-signatures-crash--cannot-read-property-name-of-null
ae4b5d6
to
a13a7c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for this
Fixes #1078