fix(eslint-plugin): [unified-signatures] crash: cannot read pro… (#1096)

Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
typescript-eslint · Nov 16, 2019 · d1de3a7 · d1de3a7
1 parent 9aee06c
commit d1de3a7
Show file tree

Hide file tree

Showing 3 changed files with 38 additions and 2 deletions.
diff --git a/packages/eslint-plugin/src/rules/unified-signatures.ts b/packages/eslint-plugin/src/rules/unified-signatures.ts
@@ -535,7 +535,8 @@ export default util.createRule({
 
       // collect overloads
       TSDeclareFunction(node): void {
-        addOverload(node, node.id.name, getExportingNode(node));
+        const exportingNode = getExportingNode(node);
+        addOverload(node, node.id?.name ?? exportingNode?.type, exportingNode);
       },
       TSCallSignatureDeclaration: addOverload,
       TSConstructSignatureDeclaration: addOverload,

diff --git a/packages/eslint-plugin/tests/rules/unified-signatures.test.ts b/packages/eslint-plugin/tests/rules/unified-signatures.test.ts
@@ -128,6 +128,14 @@ export interface Foo {
   bar(baz: string): number[];
   bar(): string[];
 }
+`,
+    `
+declare module "foo" {
+  export default function(foo: number): string[];
+}
+`,
+    `
+export default function(foo: number): string[];
 `,
   ],
   invalid: [
@@ -649,5 +657,33 @@ export function foo(line: number, character?: number): number;
         },
       ],
     },
+    {
+      code: `
+declare module "foo" {
+  export default function(foo: number): string[];
+  export default function(foo: number, bar?: string): string[];
+}
+`,
+      errors: [
+        {
+          messageId: 'omittingSingleParameter',
+          line: 4,
+          column: 40,
+        },
+      ],
+    },
+    {
+      code: `
+export default function(foo: number): string[];
+export default function(foo: number, bar?: string): string[];
+`,
+      errors: [
+        {
+          messageId: 'omittingSingleParameter',
+          line: 3,
+          column: 38,
+        },
+      ],
+    },
   ],
 });
diff --git a/packages/typescript-estree/src/ts-estree/ts-estree.ts b/packages/typescript-estree/src/ts-estree/ts-estree.ts
@@ -1061,7 +1061,6 @@ export interface TSConstructSignatureDeclaration extends FunctionSignatureBase {
 }
 
 export interface TSDeclareFunction extends FunctionDeclarationBase {
-  id: Identifier;
   type: AST_NODE_TYPES.TSDeclareFunction;
 }