chore(eslint-plugin): Add missing rule function types (#1047)

typescript-eslint · Oct 9, 2019 · a3f84e1 · a3f84e1
1 parent 054df27
commit a3f84e1
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 7 deletions.
diff --git a/packages/eslint-plugin/src/rules/indent-new-do-not-use/index.ts b/packages/eslint-plugin/src/rules/indent-new-do-not-use/index.ts
@@ -92,7 +92,6 @@ const KNOWN_NODES = new Set([
   AST_NODE_TYPES.WithStatement,
   AST_NODE_TYPES.YieldExpression,
   AST_NODE_TYPES.JSXIdentifier,
-  AST_NODE_TYPES.JSXNamespacedName,
   AST_NODE_TYPES.JSXMemberExpression,
   AST_NODE_TYPES.JSXEmptyExpression,
   AST_NODE_TYPES.JSXExpressionContainer,
@@ -164,7 +163,7 @@ const KNOWN_NODES = new Set([
   'TSPlusToken',
   AST_NODE_TYPES.TSPropertySignature,
   AST_NODE_TYPES.TSQualifiedName,
-  AST_NODE_TYPES.TSQuestionToken,
+  'TSQuestionToken',
   AST_NODE_TYPES.TSRestType,
   AST_NODE_TYPES.TSThisType,
   AST_NODE_TYPES.TSTupleType,

diff --git a/packages/eslint-plugin/src/rules/indent.ts b/packages/eslint-plugin/src/rules/indent.ts
@@ -69,7 +69,7 @@ const KNOWN_NODES = new Set([
   'TSPlusToken',
   AST_NODE_TYPES.TSPropertySignature,
   AST_NODE_TYPES.TSQualifiedName,
-  AST_NODE_TYPES.TSQuestionToken,
+  'TSQuestionToken',
   AST_NODE_TYPES.TSRestType,
   AST_NODE_TYPES.TSThisType,
   AST_NODE_TYPES.TSTupleType,

diff --git a/packages/experimental-utils/src/ts-eslint/Rule.ts b/packages/experimental-utils/src/ts-eslint/Rule.ts
@@ -226,6 +226,8 @@ interface RuleListener {
   AssignmentPattern?: RuleFunction<TSESTree.AssignmentPattern>;
   AssignmentExpression?: RuleFunction<TSESTree.AssignmentExpression>;
   AwaitExpression?: RuleFunction<TSESTree.AwaitExpression>;
+  BigIntLiteral?: RuleFunction<TSESTree.BigIntLiteral>;
+  BinaryExpression?: RuleFunction<TSESTree.BinaryExpression>;
   BlockStatement?: RuleFunction<TSESTree.BlockStatement>;
   BreakStatement?: RuleFunction<TSESTree.BreakStatement>;
   CallExpression?: RuleFunction<TSESTree.CallExpression>;
@@ -249,6 +251,8 @@ interface RuleListener {
   ForInStatement?: RuleFunction<TSESTree.ForInStatement>;
   ForOfStatement?: RuleFunction<TSESTree.ForOfStatement>;
   ForStatement?: RuleFunction<TSESTree.ForStatement>;
+  FunctionDeclaration?: RuleFunction<TSESTree.FunctionDeclaration>;
+  FunctionExpression?: RuleFunction<TSESTree.FunctionExpression>;
   Identifier?: RuleFunction<TSESTree.Identifier>;
   IfStatement?: RuleFunction<TSESTree.IfStatement>;
   Import?: RuleFunction<TSESTree.Import>;
@@ -295,6 +299,7 @@ interface RuleListener {
   ThrowStatement?: RuleFunction<TSESTree.ThrowStatement>;
   Token?: RuleFunction<TSESTree.Token>;
   TryStatement?: RuleFunction<TSESTree.TryStatement>;
+  TSAbstractClassProperty?: RuleFunction<TSESTree.TSAbstractClassProperty>;
   TSAbstractKeyword?: RuleFunction<TSESTree.TSAbstractKeyword>;
   TSAbstractMethodDefinition?: RuleFunction<
     TSESTree.TSAbstractMethodDefinition
@@ -308,24 +313,31 @@ interface RuleListener {
   TSCallSignatureDeclaration?: RuleFunction<
     TSESTree.TSCallSignatureDeclaration
   >;
+  TSClassImplements?: RuleFunction<TSESTree.TSClassImplements>;
   TSConditionalType?: RuleFunction<TSESTree.TSConditionalType>;
+  TSConstructorType?: RuleFunction<TSESTree.TSConstructorType>;
   TSConstructSignatureDeclaration?: RuleFunction<
     TSESTree.TSConstructSignatureDeclaration
   >;
   TSDeclareKeyword?: RuleFunction<TSESTree.TSDeclareKeyword>;
   TSDeclareFunction?: RuleFunction<TSESTree.TSDeclareFunction>;
+  TSEmptyBodyFunctionExpression?: RuleFunction<
+    TSESTree.TSEmptyBodyFunctionExpression
+  >;
   TSEnumDeclaration?: RuleFunction<TSESTree.TSEnumDeclaration>;
   TSEnumMember?: RuleFunction<TSESTree.TSEnumMember>;
   TSExportAssignment?: RuleFunction<TSESTree.TSExportAssignment>;
   TSExportKeyword?: RuleFunction<TSESTree.TSExportKeyword>;
   TSExternalModuleReference?: RuleFunction<TSESTree.TSExternalModuleReference>;
+  TSFunctionType?: RuleFunction<TSESTree.TSFunctionType>;
   TSImportEqualsDeclaration?: RuleFunction<TSESTree.TSImportEqualsDeclaration>;
   TSImportType?: RuleFunction<TSESTree.TSImportType>;
   TSIndexedAccessType?: RuleFunction<TSESTree.TSIndexedAccessType>;
   TSIndexSignature?: RuleFunction<TSESTree.TSIndexSignature>;
   TSInferType?: RuleFunction<TSESTree.TSInferType>;
   TSInterfaceBody?: RuleFunction<TSESTree.TSInterfaceBody>;
   TSInterfaceDeclaration?: RuleFunction<TSESTree.TSInterfaceDeclaration>;
+  TSInterfaceHeritage?: RuleFunction<TSESTree.TSInterfaceHeritage>;
   TSIntersectionType?: RuleFunction<TSESTree.TSIntersectionType>;
   TSLiteralType?: RuleFunction<TSESTree.TSLiteralType>;
   TSMappedType?: RuleFunction<TSESTree.TSMappedType>;

diff --git a/packages/parser/src/visitor-keys.ts b/packages/parser/src/visitor-keys.ts
@@ -99,7 +99,6 @@ export const visitorKeys = eslintVisitorKeys.unionWith({
   TSProtectedKeyword: [],
   TSPublicKeyword: [],
   TSQualifiedName: ['left', 'right'],
-  TSQuestionToken: [],
   TSReadonlyKeyword: [],
   TSRestType: ['typeAnnotation'],
   TSStaticKeyword: [],

diff --git a/packages/typescript-estree/src/ts-estree/ast-node-types.ts b/packages/typescript-estree/src/ts-estree/ast-node-types.ts
@@ -47,7 +47,6 @@ export enum AST_NODE_TYPES {
   JSXFragment = 'JSXFragment',
   JSXIdentifier = 'JSXIdentifier',
   JSXMemberExpression = 'JSXMemberExpression',
-  JSXNamespacedName = 'JSXNamespacedName', // https://github.com/Microsoft/TypeScript/issues/7411
   JSXOpeningElement = 'JSXOpeningElement',
   JSXOpeningFragment = 'JSXOpeningFragment',
   JSXSpreadAttribute = 'JSXSpreadAttribute',
@@ -135,7 +134,6 @@ export enum AST_NODE_TYPES {
   TSProtectedKeyword = 'TSProtectedKeyword',
   TSPublicKeyword = 'TSPublicKeyword',
   TSQualifiedName = 'TSQualifiedName',
-  TSQuestionToken = 'TSQuestionToken',
   TSReadonlyKeyword = 'TSReadonlyKeyword',
   TSRestType = 'TSRestType',
   TSStaticKeyword = 'TSStaticKeyword',

diff --git a/packages/typescript-estree/src/ts-estree/ts-estree.ts b/packages/typescript-estree/src/ts-estree/ts-estree.ts
@@ -465,7 +465,7 @@ interface ClassDeclarationBase extends BaseNode {
 
 interface ClassPropertyBase extends BaseNode {
   key: PropertyName;
-  value: Expression;
+  value: Expression | null;
   computed: boolean;
   static: boolean;
   readonly?: boolean;