Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add usage of box shadow variable #39976

Closed

Conversation

imanmalekian31
Copy link

Description

When I wanted to use popover box shadow, I noticed there is $popover-box-shadow but it is never used and doesn't get applied to popover. So I've added box-shadow to popover class.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@imanmalekian31 imanmalekian31 requested a review from a team as a code owner May 12, 2024 09:27
@julien-deramond
Copy link
Member

Hello @imanmalekian31
Thanks for creating a PR. However, as mentioned in our Contributing Guidelines:

Do not edit bootstrap.css or bootstrap.js, and do not commit any dist files (dist/ or js/dist). Those files are automatically generated by our build tools. You should edit the source files in /bootstrap/scss/ and/or /bootstrap/js/src/ instead.

Closing this PR. Feel free to open a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants